Re^3: Perl subroutine update

Well, sure, if you turn off warnings, naturally you get no warnings, but you are ignoring things that hint at problems with your code. By removing strict, you get fewer errors, but you also get no information when you mistype variable names. Do you think a script works better if it shows no error message but simple prints the wrong result? This is how politicans solve problems, by removing the warning signs ;-)

You still haven't changed $element1 to @element1 in this script. Did you notice that you call your subroutine as "decko" in line 21?

Another problem: you should not use foreach on an array when you change the array inside with pop,shift and push. Normally it leads to fewer loop executions as expected. In your case it is even fortunate that it does so because if it had run for every element in the array, your array would have only 1 or 2 cards left because you are constantly dropping cards (i.e. removing them from the array) with your broken shuffle

Look at the script I posted to your first post about this problem in Re: Perl Subroutine. Notice that I used a different loop. I did it because foreach is not the right choice here

Comment on Re^3: Perl subroutine update

Replies are listed 'Best First'.
Re^4: Perl subroutine update by craziestfire73 (Initiate) on Apr 05, 2011 at 17:56 UTC
sorry for the mistakes, I have been working on this for days and getting kind of frustrated, but I won't be better until I get the code right. ################test.pl############ #!/usr/bin/perl -w use strict; require 'test-lib.pl' my @startingdeck = ("A H","2 H","3 H","4 H","5 H","6 H","7H","8 H", "9 H","10 H","J H","Q H","K H", "A D","2 D","3 D","4 D","5 D","6 D","7 D","8 D", "9 D","10 D","J D","Q D","K D", "A C","2 C","3 C","4 C","5 C","6 C","7 C","8 C", "9 C","10 C","J C","Q C","K C", "A S","2 S","3 S","4 S","5 S","6 S","7 S","8 S", "9 S","10 S","J S","Q S","K S"); my @random_cards= @startingdeck; my $x = 0; foreach(@cards){ $_ =~ s/C/Clubs/, s/S/Spades/, s/H/Hearts, s/D/Diamonds/; } my @cards = deckof(@cards); my @newcards = deckof(@cards); print "@cards[$_], @newcards[$_]\n" for 0..4; $x++; [download] ############test-lib.pl############ `#!/usr/bin/perl -w use strict; sub deckof{ my @cards = @_; foreach my $card(1...30){ my @elements1 = (pop(@cards), shift(@cards), pop(@cards)); my @elements2 = (shift(@cards), pop(@cards), shift(@cards)); push(@cards, @elements1, @elements2); } return @cards; } 1;` [download]	[reply] [d/l] [select]

Replies are listed 'Best First'.

Re^4: Perl subroutine update
by craziestfire73 (Initiate) on Apr 05, 2011 at 17:56 UTC

sorry for the mistakes, I have been working on this for days and getting kind of frustrated, but I won't be better until I get the code right.

################test.pl############

#!/usr/bin/perl -w
use strict;
require 'test-lib.pl'

my @startingdeck = ("A H","2 H","3 H","4 H","5 H","6 H","7H","8 H",
                    "9 H","10 H","J H","Q H","K H",
                    "A D","2 D","3 D","4 D","5 D","6 D","7 D","8 D",
                    "9 D","10 D","J D","Q D","K D",
                    "A C","2 C","3 C","4 C","5 C","6 C","7 C","8 C",
                    "9 C","10 C","J C","Q C","K C",
                    "A S","2 S","3 S","4 S","5 S","6 S","7 S","8 S",
                    "9 S","10 S","J S","Q S","K S");
my @random_cards= @startingdeck;
my $x = 0;

foreach(@cards){
    $_ =~ s/C/Clubs/, s/S/Spades/, s/H/Hearts, s/D/Diamonds/;
}

my @cards = deckof(@cards);
my @newcards = deckof(@cards);
print "@cards[$_],  @newcards[$_]\n" for 0..4;
$x++;
[download]

############test-lib.pl############

#!/usr/bin/perl -w
use strict;

sub deckof{
    my @cards = @_;

    foreach my $card(1...30){
        my @elements1 = (pop(@cards), shift(@cards), pop(@cards));
        my @elements2 = (shift(@cards), pop(@cards), shift(@cards));

        push(@cards, @elements1, @elements2);
    }
    return @cards;
}
1;
[download]

[reply]
[d/l]
[select]