Anonymous Monk has asked for the wisdom of the Perl Monks concerning the following question:

Trying to create a file in temp folder using the below line of code,always get "Failed to create cfg".what am I dong wrong? 

open(CFG, "C:\\TEMP\\cfg") || die "Failed to create cfg";

[download]

Replies are listed 'Best First'.
Re: Failed to create a file
by wind (Priest) on May 06, 2011 at 02:43 UTC

    Read the documentation for open. You're currently trying to open for reading instead of writing.

    Also, give yourself all the debugging information possible in your die statements. It would've told you what was wrong.

    my $file = "C:\\TEMP\\cfg";
open CFG, '>', $file or die "failed to open $file: $!";

    [download]
[reply]
[d/l]
Re: Failed to create a file
by ikegami (Patriarch) on May 06, 2011 at 07:12 UTC
[reply]
Re: Failed to create a file
by Khen1950fx (Canon) on May 06, 2011 at 03:20 UTC
    I don't have Windows, so this is untested:); 
    #!perl

use strict;
use warnings;

open STDOUT, '>', 'C:\\TEMP\\cfg'
    or die "Failed to create cfg";
print "Does this work?\n";
close STDOUT;

    [download]
[reply]
[d/l]
    A reply falls below the community's threshold of quality. You may see it by logging in.
Re: Failed to create a file
by MidLifeXis (Monsignor) on May 06, 2011 at 13:09 UTC

    Slightly off topic, but related to coding style of sorts.

    open(CFG, "C:\\TEMP\\cfg") || die "Failed to create cfg";

    You have included the parens in your call to open, which allows the ... || die ... to work as expected. If you leave off the parens - open CFG, "C:\\TEMP\\cfg" || die "Failed to create cfg";, this will give you the wrong results. Having stubbed my toe on this many times, I have made it my habit to use action or die instead of action || die.

    --MidLifeXis

[reply]
[d/l]
[select]

      An even alternativer solution to this is to use pjf's great autodie module, which avoids the issue altogether...


      What can be asserted without proof can be dismissed without proof. - Christopher Hitchens
[reply]
      Having stubbed my toe on this many times, I have made it my habit to use action or die instead of action || die.
      An alternative reaction is to always use parens on function calls: some_function(ARGS) || die. The advantage of this strategy is that it improves readability, plus now you don’t have to memorize a bunch of confusing and conflicting precedence rules.
[reply]
[d/l]
[select]
        I'm curious, which precedence rules are "conflicting"?

        Also I find the rule "logical operators that are spelled out as words have loose precedence" not too hard to remember.

        Perl 6 - second systems done right
[reply]
Re: Failed to create a file
by jellisii2 (Hermit) on May 06, 2011 at 13:05 UTC
    mkdir('C:/TEMP/cfg') or die 'Could not create folder';
[reply]
[d/l]

Back to Seekers of Perl Wisdom