regex for perl script

Anonymous Monk has asked for the wisdom of the Perl Monks concerning the following question:

Replies are listed 'Best First'.
Re: regex for perl script by Utilitarian (Vicar) on May 15, 2011 at 16:24 UTC
You don't need a regex to extract the IP from that log, it's always in the same position `while(<$logfile>){ push @ip_addresses, (split / /, $_)[2]; }` [download] `print "Good ",qw(night morning afternoon evening)[(localtime)[2]/6]," fellow monks."`	[reply] [d/l] [select]
Re^2: regex for perl script by rev_1318 (Chaplain) on May 15, 2011 at 17:25 UTC
Almost; but that will retain the ',' after the IP-address; use split /, / instead. Paul	[reply]
Re^3: regex for perl script by Anonymous Monk on May 15, 2011 at 20:14 UTC
Thanks for you feedbacks dude. I'm sorry to say that i'm unable to fit the code into the script. I'm novice to perl. Here's the full script: Read more... (31 kB) I've another dovecot log file which also logs login info. If the script extract rip from this log that's also fine: 2011-05-15 16:10:10 pop3-login: Info: Login: user=<test@example.com>, +method=PLAIN, rip=180.234.57.184, lip=166.165.52.15 2011-05-15 16:10:11 POP3(test@example.com): Info: Disconnected: Logged + out top=0/0, retr=0/0, del=0/0, size=0 2011-05-15 16:10:14 pop3-login: Info: Login: user=<test@example.com>, +method=PLAIN, rip=180.234.57.184, lip=166.165.52.15 2011-05-15 16:10:15 POP3(test@example.com): Info: Disconnected: Logged + out top=0/0, retr=0/0, del=0/0, size=0 2011-05-15 16:10:17 pop3-login: Info: Login: user=<test@example.com>, +method=PLAIN, rip=180.234.57.184, lip=166.165.52.15 2011-05-15 16:10:18 POP3(test@example.com): Info: Disconnected: Logged + out top=0/0, retr=0/0, del=0/0, size=0 [download]	[reply] [d/l] [select]
Re^4: regex for perl script by ww (Archbishop) on May 15, 2011 at 20:41 UTC
Re^4: regex for perl script by davido (Cardinal) on May 15, 2011 at 20:56 UTC
Re^5: regex for perl script by Anonymous Monk on May 16, 2011 at 18:14 UTC
Re^4: regex for perl script by marinersk (Priest) on May 16, 2011 at 12:54 UTC
Re: regex for perl script by Khen1950fx (Canon) on May 15, 2011 at 21:26 UTC
Personally, I don't use regexen with IP addresses. There's a node that was written in 2002 that covers some of the pitfalls that you'll encounter. See: Don't Use Regular Expressions to Parse IP Addresses! While using regexen for server logfiles is OK, they can turn on you.	[reply]
Re: regex for perl script by AnomalousMonk (Archbishop) on May 15, 2011 at 23:00 UTC
When you finish negotiating with your consultant to alter your script, you might suggest he or she investigate Regexp::Common and Regexp::Common::net for IPv4 addresses.	[reply]
Re: regex for perl script by CountZero (Bishop) on May 16, 2011 at 06:36 UTC
Things like "The regex syntax provided there is not working for me actually" (without even given the regex that is not working) and "i'm unable to fit the code into the script" (followed by 643 lines of code you have not written yourself), will not get you any useful answer here. Why don't you contact the author of that code? CountZero A program should be light and agile, its subroutines connected like a string of pearls. The spirit and intent of the program should be retained throughout. There should be neither too little or too much, neither needless loops nor useless variables, neither lack of structure nor overwhelming rigidity." - The Tao of Programming, 4.1 - Geoffrey James	[reply]
Re^2: regex for perl script by Anonymous Monk on May 16, 2011 at 13:13 UTC
I've got it working. `'^(\d\d\d\d-\d+-\d+ \d+:\d+:\d+) (?:imap\|pop3)-login: Info: ' . 'Login: .? (?:\[\|rip=)[:f](\d+\.\d+\.\d+\.\d+)[],]';` [download] Thanks.	[reply] [d/l]
Re^3: regex for perl script by Khen1950fx (Canon) on May 16, 2011 at 20:25 UTC
Just in case the regex gets crazy on you, fall back to Text::CSV::Simple. `#!/usr/bin/perl use strict; use warnings; use Text::CSV::Simple; use Data::Dump qw(dump); my $logfile = "/root/Desktop/ip.log"; my $parser = Text::CSV::Simple->new; $parser->want_fields(2); my @data = $parser->read_file($logfile); print dump(@data);` [download]	[reply] [d/l]