Re^3: Reading Multiple Input Files

Ouch, C-style for loops in Perl.

A more Perlish approach is

while ( my ($index, $file) = each @filenames) {... }
[download]

No need to calculate the number of files, you don't need to use indexes to access the filename and you still have the $index variable to use in composing the output filenames.

CountZero

A program should be light and agile, its subroutines connected like a string of pearls. The spirit and intent of the program should be retained throughout. There should be neither too little or too much, neither needless loops nor useless variables, neither lack of structure nor overwhelming rigidity." - The Tao of Programming, 4.1 - Geoffrey James

Comment on Re^3: Reading Multiple Input Files Select or Download Code

Replies are listed 'Best First'.
Re^4: Reading Multiple Input Files by Anonymous Monk on May 28, 2011 at 08:55 UTC
Ouch indeed :D I have been visiting perlmonks for 10 years and never seen that once, and I did write the c-style version at least 5 times. Correction, I did see it once last year in Re: Perl v5.13.7 is released, but it wasn't in actual code. Its not that surprising, there is no example in each documentation. I did a super search for "each @" and only found this 3 instances of actual use in 10 years (search yielded ~47 nodes, "each@" yielded 4 nodes ) (newest first) Re: Searching through a document and reporting results. Re: Getting values for next array iteration when matching current Re: What's missing in Perl 5.10 This is worthy of poll quest. update: Oh, it wasn't available until 12 Apr 2010 ( p5123-keys, values work on arrays), now I don't feel so bad :)	[reply]
Re^5: Reading Multiple Input Files by CountZero (Bishop) on May 28, 2011 at 11:30 UTC
Oops, sorry indeed. I forgot to mention I run everything under "`use Modern::Perl;`"; CountZero A program should be light and agile, its subroutines connected like a string of pearls. The spirit and intent of the program should be retained throughout. There should be neither too little or too much, neither needless loops nor useless variables, neither lack of structure nor overwhelming rigidity." - The Tao of Programming, 4.1 - Geoffrey James	[reply] [d/l]