in reply to Re^4: Problem with CGI::Vars
in thread Problem with CGI::Vars

I think, I found a BUG in CGI module....

Seeing how thus far, you haven't relayed any version information, it is extremely unlikely you found a bug. The code you copy/pasted doesn't match the current version of CGI module.

This looks ok, but the function calling looks like, it program some kid:

You can always write your own

Replies are listed 'Best First'.
Re^6: Problem with CGI::Vars
by Chipper (Initiate) on Jun 07, 2011 at 12:49 UTC
    Yes I can, but we use this library... The code in new version of this function is the same! Tell me why they read from STDIN by read function and they didn't check how many bytes function read? This is the basics... The problem is in file: CGI.pm in this function: 
    if ($meth eq 'POST') {
  $self->read_from_client(\$query_string,$content_length,0)
      if $content_length > 0;
  
  # Some people want to have their cake and eat it too!
  # Uncomment this line to have the contents of the query string
  # APPENDED to the POST data.
  #$query_string .= (length($query_string) ? '&' : '') . $ENV{'QUERY_S
+TRING'} if defined $ENV{'QUERY_STRING'};
                                                           
  last METHOD;
}

    [download]
    As I checked by debug prints, function read only 10000 bytes, and 3100 bytes keeps unreaded. This function have to be in while cycle....
[reply]
[d/l]

      At least CGI v3.35 has this code, which is different from the code you show:

            if ($meth eq 'POST' || $meth eq 'PUT') {
      if ( $content_length > 0 ) {
        $self->read_from_client(\$query_string,$content_length,0);
      }
      elsif (not defined $ENV{CONTENT_LENGTH}) {
        $self->read_from_stdin(\$query_string);
        # should this be PUTDATA in case of PUT ?
        my($param) = $meth . 'DATA' ;
        $self->add_parameter($param) ;
        push (@{$self->{param}{$param}},$query_string);
        undef $query_string ;
      }
      # Some people want to have their cake and eat it too!
      # Uncomment this line to have the contents of the query string
      # APPENDED to the POST data.
      # $query_string .= (length($query_string) ? '&' : '') . $ENV{'QU
+ERY_STRING'} if defined $ENV{'QUERY_STRING'};
      last METHOD;
      }

      [download]

      If you're using an old version of CGI.pm it makes little sense to complain about bugs in the old version when a newer version which is different is available.

[reply]
[d/l]
[select]
        OK it is different, but also there is only one read_from_client call!!! If read_from_client function doesn't read whole input, then problem is not solved too...
[reply]
      Yes I can, but we use this library... The code in new version of this function is the same! Tell me why they read from STDIN by read function and they didn't check how many bytes function read? This is the basics... The problem is in file: CGI.pm in this function:

      Um, no. Let me repeat that: no.

      There is no point in quoting bits and pieces of some old version of CGI.pm.

      On the other hand, there is no point in quoting bits and pieces of CGI.pm at all.

      You think you found a bug? Great, submit a proper bug report to the CGI maintainer. What version of CGI.pm do you have installed?

[reply]
        By the way: I reported bug, but no response from CGI maintainer..
[reply]
        Version of CGI.pm: 3.15 Perl version: v5.8.8 built for x86_64-linux-thread-multi Web server: MiniServ/1.530 OS: Linux vmluh03 2.6.32lb.11.kvmguest #1 SMP PREEMPT Tue Apr 6 12:56:36 CEST 2010 x86_64 x86_64 x86_64 GNU/Linux
[reply]

In Section Seekers of Perl Wisdom