Okay, it might be that I am returning in that loop, so the matches aren't being kept! How do I prevent the matches that the condition is true for from getting to @all_matches but reaching @all_pronoun_matches?

I think you want next or last instead of return. Return exits a subroutine, last exits a loop.