Re: perl do's and don'ts

You are using a global variable $decimal in sub convb2d. It would be cleaner to pass that value as an argument to the routine, such as

convb2d($decimal);
sub convb2d {
    my $decimal = unpack 
( "N", pack("B32", substr("0" x 32 . $_[0], -32 )));
print ("Decimal: $decimal\n");
exit;
}
[download]

The naming of your routine, sub convb2d would imply to me that it was going to perform a conversion. However, it actually does the conversion, prints the result, and then exits the program. I would have the routine instead simply perform the conversion, and return the result. Imagine future uses -- would this routine be useful if you then wanted to sum up a group of binary numbers in decimal? It wouldn't... but if you did...
```
$decimal = convb2d($decimal);
sub convb2d {
    return unpack 
( "N", pack("B32", substr("0" x 32 . $_[0], -32 )));
}
[download]
```
You no longer need the extra variable and can now use this function in many more ways.
You don't need '()' around print strings.
The previous authors suggestion regarding the regular expression is very good as well.

Comment on Re: perl do's and don'ts Select or Download Code