in reply to Re^10: odd line in windows
in thread odd line in windows

newSVrv doesn't create a reference as a I had guessed, it returns a new SV and makes obj_ref a reference to it. WTF? How odd is that!!!

Very odd!

There's nothing like consistency:

  1. newSViv: Creates a new SV and copies an integer into it
  2. newSVnv: Creates a new SV and copies a floating point value into it.
  3. newSVpv: Creates a new SV and copies a string into it.
  4. newSVrv: Creates a new SV for the RV, rv, to point to.

And that's nothing like consistent! newRVsv() would make more sense (IMO).

Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
"Science is about questioning the status quo. Questioning authority".
In the absence of evidence, opinion is indistinguishable from prejudice.

Replies are listed 'Best First'.
Re^12: odd line in windows
by ikegami (Patriarch) on Sep 08, 2011 at 22:50 UTC

    Here's an alternative way of writing the function that might be clearer. 

    SV* new(const char * classname, const char * name, const char * rank, 
+long serial) {
    Soldier * soldier;
    SV      * obj;
    SV      * obj_ref;

    New(42, soldier, 1, Soldier);
    soldier->name = savepv(name);
    soldier->rank = savepv(rank);
    soldier->serial = serial;

    obj = newSViv((IV)soldier);
    obj_ref = newRV_noinc(obj);
    sv_bless(obj_ref, gv_stashpv(classname, GV_ADD));
    SvREADONLY_on(obj);

    return obj_ref;  // Inline will mortalize.
}

    [download]
[reply]
[d/l]

      Indeed. That is much clearer.

      syphilis if you are following along, it would be worth updating the POD with that example

      Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
      "Science is about questioning the status quo. Questioning authority".
      In the absence of evidence, opinion is indistinguishable from prejudice.
[reply]
        syphilis if you are following along, it would be worth updating the POD with that example

        Done in the git version.

        Cheers,
        Rob
[reply]

In Section Seekers of Perl Wisdom