Re: log4perl and efficiency

The Log::Log4perl POD has a section with ways to improve log4perl performance. It looks to me like you should wrap that log string into a function so it doesn't need to interpolate when logging is off.

Comment on Re: log4perl and efficiency

Replies are listed 'Best First'.
Re^2: log4perl and efficiency by erwan (Sexton) on Sep 12, 2011 at 17:30 UTC
Unless I misunderstood, that's what I did. well, not using a function but the "if (condition) { log }" does the same thing, doesn't it?	[reply]
Re^3: log4perl and efficiency by Solo (Deacon) on Sep 12, 2011 at 17:44 UTC
That's one approach. I was suggesting: `$self->{logger}->trace( sub { "total NbObsThis $i=$nbObservedThisNGram +->[$i]; nbObsAll $i=$nbObservedAllNGrams->[$i]; total=$totalObservedA +ll; nbExpected $i=$nbExpectedThis[$i]; chisq = $chiSquare[$i]" } );` [download] which may be easier to bulk modify in source while maintaining existing log levels. (or not. YMMV.)	[reply] [d/l]
Re^4: log4perl and efficiency by erwan (Sexton) on Sep 12, 2011 at 17:54 UTC
ok, I didn't realize this advantage. thanks for the explanation!	[reply]