Try this. Note that I changed it so that OWNER and WAITING are arrayrefs, hence the push. You'll probably want to add data validation too...

Update:I made two late adjustments after 'strict'.

use strict;
use warnings;
use Data::Dumper;
my %records;
my $state;   # UPDATE - Added this!
while(<DATA>){
   my @fields = split;  # and added 'my'
   if ($fields[5] =~ /(OWNER|WAITING)/) {
      $state = $1;
   } else {
      push@{$records{$fields[1]}{$state}}, 
              {
                USER     => $fields[5],
                FILENAME => $fields[0],
                PID      => $fields[6],
                TIME     => $fields[9], 
                DATE     => "$fields[10] $fields[11]", 
                ELAPSED => []
              };
   }
}
print Dumper(%records);
[download]

Partial Output:

$VAR21 = '001!SCHEDULE';
$VAR22 = {
           'WAITING' => [
                          {
                            'PID' => '33',
                            'TIME' => undef,
                            'DATE' => ' ',
                            'ELAPSED' => [],
                            'FILENAME' => '/ud/QC-DATA/CONTROL',
                            'USER' => 'marshall'
                          },
                          {
                            'PID' => '4565',
                            'TIME' => undef,
                            'DATE' => ' ',
                            'ELAPSED' => [],
                            'FILENAME' => '/ud/QC-DATA/CONTROL',
                            'USER' => 'steven'
                          }
                        ],
           'OWNER' => [
                        {
                          'PID' => '500',
                          'TIME' => undef,
                          'DATE' => ' ',
                          'ELAPSED' => [],
                          'FILENAME' => '/ud/QC-DATA/CONTROL',
                          'USER' => 'richard'
                        }
                      ]
         };
[download]

            if ($fields[5] =~ /(OWNER|WAITING)/) 
            {
                $x++;
                $state = $1;
                if ($state eq 'OWNER') { $count = 0; }
                if ($state eq 'WAITING') { $state .= "-$count"; $count
+++; }
                @fields = split " ", $temp[$x];
                print "$state --- @fields\n";
                #Add record to hash based on RECORD_ID
                $records{"$fields[1]"}{ $state } = {
                    USER => "$fields[5]", 
                    FILENAME => "$fields[0]",  
                    PID => "$fields[6]", 
                    TIME => "$fields[9]", 
                    DATE => (join " ", "$fields[10] $fields[11]"), 
                    ELAPSED => []
                };
                #Increment to Next Line
                $x++;
                }
            else {
                $records{"$fields[1]"}{ "WAITING-$count" } = {
                    USER => "$fields[5]", 
                    FILENAME => "$fields[0]",  
                    PID => "$fields[6]", 
                    TIME => "$fields[9]", 
                    DATE => (join " ", "$fields[10] $fields[11]"), 
                    ELAPSED => []
                };
                $count++;
                $x++;
            }
[download]

Matt--

Consider reading your data one line at a time, rather than slurping into an array and manipulating $x.

Also, here:

   DATE => (join " ", "$fields[10] $fields[11]"),
[download]

The double-quotes on the right side bind the tenth and eleventh fields into a single string, which you then join(?) with a space. Joining a single item doesn't do anything; you can simply do:

   DATE => "$fields[10] $fields[11]"
[download]

Hey hbm, thanks for the reply.

I tried reading the data into the hash at first but it was just confusing the crap out of me (trying to use @_ or $_ and also $line) so I did the array thing just to get myself started. Once I get more comfortable with hashes, most likely by the end of this, I will probably go back and change it to what you suggested.

haha Yeah your right, I guess it is pointless to use "join" when only joining 2 elements. Good point, thanks.


I was working on this thing below that I am kinda stuck on. Maybe you could see what I am not doing right.
What I want to do is: I have this new SUB, also a new array (@colLens used this method before with a 2D-Array and it worked good). @colLens has 0..7 elements, same as the amount of fields per each record.

What it will do is, loop through the hash and if the current hash element's length is greater than the value in the same position in @colLens, then that element in @colLens will now big the bigger of the two. So the end effect will be that @colLens holds the largest length of each hash element 0..7 .


Here's what I tried:

my @header = ("RECORD_ID", "STATUS", "PID", "TIME", "DATE", "HELD/WAIT
+ING", "FILENAME", "USER");
my @colLens;

sub getColumnLengths()
{
    for (my $y = 0; $y <= $#header; $y++) {
        $colLens[$y] = length($header[$y]);
    }

    my $x;
        # $rec1 = RECORD_ID
    for my $rec1 ( keys %records )
    {
        $x = 0;
        if (int($colLens[$x]) < length($rec1)) {
            $colLens[$x] = length($rec1);
        }
                # $rec2 = STATUS
        for my $rec2 ( keys %{ $records{$rec1} } )
        {
            $x = 1;
            if (int($colLens[$x]) < length($rec2)) {
                $colLens[$x] = length($rec2);
            }
            $x++;
            # $rec3 = PID, TIME, DATE, ELAPSED, FILENAME, USER
            for my $rec3 ( keys %{$records{$rec1}{$rec2}} )
            {                
                if (int($colLens[$x]) < int(length($rec3))) {
                    $colLens[$x] = int(length($rec3));
                }

                $x++;
            }#END INNER-MOST
        }#END MID
    }#END OUTER
}
[download]


From my output I get it seems that it is working for just the first 2 elements, not sure why the rest isn't? I'm assuming it is something with my inner-most loop...


If you can think of anything please let me know.

Thanks in Advance,
Matt