in reply to code for review
Here's a small bit. What's the point of this?
$outpath1= $outpath; mkdir "$outpath1"; $outpath= $outpath1; $outpath .= 'affprint.html';
You assign the value of $outpath to $outpath1, just to make the directory, then assign the value back to $outpath, which it already has since the value just came from there, then never use $outpath1 again. Why not just mkdir $outpath and forget $outpath1?
Also, this isn't C; you don't need to pre-declare your variables at the start of the program before you use them. Just create them with my when you assign values to them. One other tiny thing: quotes around a single scalar like you have following mkdir are unnecessary, and may cause confusion.
|
|---|