in reply to Rate my patch: fix -Dusesitecustomize + -Duserelocatableinc

Without looking at the content, I'll just have to say that PerlMonks is not the right place to propose these kind of changes. Those who know more about this are on the Perl5 Porters Mailing List. Feel free to post it there.


Enjoy, Have FUN! H.Merijn
  • Comment on Re: Rate my patch: fix -Dusesitecustomize + -Duserelocatableinc

Replies are listed 'Best First'.
Re^2: Rate my patch: fix -Dusesitecustomize + -Duserelocatableinc
by zengargoyle (Deacon) on Nov 18, 2011 at 12:44 UTC

    I have posted it (well, an earlier hackier version) to p5p. I'm looking more for things like: mayberelocate() is an awful function name. that's not how you use SvREFCNT_dec(). you should put your function above S_incpush_if_exists(). needs more comments.

    I'd like to improve my chances of my patch being accepted before submitting it via perlbug. It might get overlooked or just passed over for being too crude on p5p, and well, the more looking over it gets the better.

      Those are all laudable goals!


      Enjoy, Have FUN! H.Merijn
Re^2: Rate my patch: fix -Dusesitecustomize + -Duserelocatableinc
by Anonymous Monk on Nov 18, 2011 at 11:57 UTC

    Without looking at the content, I'll just have to say that PerlMonks is not the right place to propose these kind of changes.

    Sure it is