Re: ModPerl::Registry error

mod_perl analyses shebang line and adds use warnings if it contains -w switch, so yours

use warnings qw(redefine);
[download]

doesn't really make much sense, all warnings are enabled.

As a side note, passing arguments to the functions via global variables is not a good idea. All these local our ... look terrible and just asking for trouble. Even if they were not global, it's just to many of them, I'd recommend you to group some of them together into nice data structures.

Comment on Re: ModPerl::Registry error Select or Download Code

Replies are listed 'Best First'.
Re^2: ModPerl::Registry error by Anonymous Monk on Dec 20, 2011 at 10:29 UTC
Hi, I posted the wrong code accidentally, I just wanted to turn on the warnings, to see if I could get some clue about the error message. I put back `no warnings qw(redefine);` but it still gives me the same errors. Any other ideas ? Apart from looking terrible, what is wrong with using local our variables?	[reply] [d/l]
Re^3: ModPerl::Registry error by Anonymous Monk on Dec 20, 2011 at 12:04 UTC
Apart from looking terrible, what is wrong with using local our variables? It is a very obvious symptom of lack of experience :) The "wrong" way `local our $foo = 1; Dance(); sub Dance { print "I win, $foo\n"; }` [download] The "right" way `Dance( 1 ); sub Dance { my( $foo ) = @_; print "I win, $foo\n"; }` [download] See Tutorials: Variable Scoping in Perl: the basics, Coping with Scoping See also http://learn.perl.org/books/beginning-perl/ and the Modern Perl Book	[reply] [d/l] [select]