This code looks almost identical to a series of nodes from an anon OP last summer. Grouping files before zipping!, Zipping Files Help!: I remember some things being recommended like basic debugging skills using print statements, showing the errors / results you get. Have you read How do I post a question effectively? ?