Re: Web form to alter files is writing to file before submit button is pressed.

Replies are listed 'Best First'.
Re^2: Web form to alter files is writing to file before submit button is pressed. by Anonymous Monk on Mar 11, 2012 at 09:42 UTC
since people can submit forms by hitting Enter on a text field, in which case the named submit button isn't referenced. Just FWIW, last I heard, only IE does that. The other browsers will send a submit argument. As for what to do to avoid that, I either check that the request is POST, or check for a required param's existence. If the request does something that is not read-only (like the OP's script seems to do), I'd very strongly consider changing the form submission to POST from GET.	[reply]
Re^3: Web form to alter files is writing to file before submit button is pressed. by Anonymous Monk on Mar 11, 2012 at 09:59 UTC
If the request does something that is not read-only (like the OP's script seems to do), I'd very strongly consider changing the form submission to POST from GET. That is against the common accepted wisdom of Post/Redirect/Get	[reply]
Re^4: Web form to alter files is writing to file before submit button is pressed. by Anonymous Monk on Mar 11, 2012 at 13:05 UTC
I don't see how that has anything to do with this case -- except that the OP is missing a redirect. As it is now, if the user reloads the page, the form will get re-submit (and the file modified) without a single warning. If the method is a POST, the browser will at least warn the user that he may not want to do the reload.	[reply]
Re^5: Web form to alter files is writing to file before submit button is pressed. by Anonymous Monk on Mar 12, 2012 at 07:45 UTC
Re^6: Web form to alter files is writing to file before submit button is pressed. by Lady_Aleena (Priest) on Mar 12, 2012 at 17:46 UTC
Re^2: Web form to alter files is writing to file before submit button is pressed. by Lady_Aleena (Priest) on Mar 11, 2012 at 19:26 UTC
Thank you for mentioning hitting enter. I should have considered that in the original post. *Have a cookie and a very nice day!* Lady Aleena	[reply]
Re^3: Web form to alter files is writing to file before submit button is pressed. by tangent (Parson) on Mar 11, 2012 at 19:44 UTC
I often use CGI::Minimal to see what is going on with form inputs. It has a handy function called "calling_parms_table()" which returns a HTML table of all form and environment variables. It will show you what happens when you hit Enter instead of pressing the button - the result seems to vary across different browsers. This becomes important if, say, you had two buttons on the form: make_changes and undo_changes.	[reply]
Re^4: Web form to alter files is writing to file before submit button is pressed. by Anonymous Monk on Mar 12, 2012 at 08:05 UTC
"calling_parms_table()" CGI/CGI::Simple provide `my $q = CGI->new; print $cgi->header(), $q->dump, '<hr>', CGI->new( \%ENV )->Dump;` [download] I don't think I'd use CGI::Minimal, it appears to be too not well tested, the bug cue is very empty	[reply] [d/l]
Re^2: Web form to alter files is writing to file before submit button is pressed. by Anonymous Monk on Mar 11, 2012 at 14:20 UTC
the OP wants to know if the submit button has been pressed, as stated in the title, not if the enter key has been hit.	[reply]
Re^3: Web form to alter files is writing to file before submit button is pressed. by Lady_Aleena (Priest) on Mar 11, 2012 at 17:21 UTC
Don't worry, I'm glad that using the enter key has been brought up in this discussion since not everyone uses just the buttons presented. I forgot to take that into consideration, and I use the enter key to submit data a lot of the time. I should have thought of it when posting the original post of this discussion. *Have a cookie and a very nice day!* Lady Aleena	[reply]