Re: What I am missing here

Riales is spot-on; using Data::Dumper to dump out @deck at several places will show this quickly enough.

As an aside, I spotted another issue when I was looking at this, and couldn't run it as-shown. There's some needless complexity in sub deck_maker, which I simplified to this:

#DECK MAKER
sub deck_maker {
    my @deck = (); #the deck for returning
    my @types = ('spades', 'hearts', 'diamonds', 'clubs');
    my @cards = ( 2,3,4,5,6,7,8,9,10,'J','Q','K','A');
    for ( my $i=0; $i < 4; $i++) {
        for ( my $j=0; $j < 13; $j++) {
            my $newcard = $cards[$j] . " of " . $types[$i];
            push(@deck, $newcard);
        }
    }
    return @deck; #return the new deck
}
[download]

D Ruth Bavousett

Comment on Re: What I am missing here Select or Download Code

Replies are listed 'Best First'.
Re^2: What I am missing here by MidLifeXis (Monsignor) on Mar 20, 2012 at 20:22 UTC
Perhaps a little bit easier using some perl idioms... `#DECK MAKER sub deck_maker { my @deck = (); #the deck for returning my @suits = qw( spades hearts diamonds clubs ); my @cards = ( 2..10, qw(J Q K A) ); for my $suit ( @suits ) { for my $card ( @cards ) { my $newcard = "$card of $suit"; push(@deck, $newcard); } } return @deck; #return the new deck }` [download] --MidLifeXis	[reply] [d/l]
Re^3: What I am missing here by tobyink (Canon) on Mar 20, 2012 at 21:31 UTC
Can go simpler... `sub deck_maker { map { my $suit = $_; map { "$_ of $suit" } 2..10, qw(J Q K A) } qw(spades hearts diamonds clubs); }` [download] `perl -E'sub Monkey::do{say$_,for@_,do{($monkey=[caller(0)]->[3])=~s{::}{ }and$monkey}}"Monkey say"->Monkey::do'`	[reply] [d/l]
Re^4: What I am missing here by heatblazer (Scribe) on Mar 21, 2012 at 05:21 UTC
Yes, I got that but I want to be more explicit of what is going on... my pick_a_card could be just : `sub pick_a_card { pop; }` [download] but I prefer it my way	[reply] [d/l]
Re^4: What I am missing here by tobyink (Canon) on Mar 23, 2012 at 22:44 UTC
With List::MapMulti this can be reduced to: `sub deck_maker { mapm { join " of ", @_ } [ 2..10, qw(J Q K A) ], [ qw(spades hearts diamonds clubs) ] }` [download] `perl -E'sub Monkey::do{say$_,for@_,do{($monkey=[caller(0)]->[3])=~s{::}{ }and$monkey}}"Monkey say"->Monkey::do'`	[reply] [d/l]
Re^3: What I am missing here by heatblazer (Scribe) on Mar 21, 2012 at 05:17 UTC
Yes, it is, but I prefer to really be more verbose about my code.	[reply]
Re^4: What I am missing here by heatblazer (Scribe) on Mar 21, 2012 at 05:28 UTC
Your options are interesting and different, I prefer to code in my own style in perl, after all it`s tim towdi rule :), but I still don`t get why my pick_a_card does pops 4 times the same value???	[reply]