Re^2: Same problem replacing array index numbers

Please let me to improve your code:

my $s = 'xx @ra[1] y @ara[23] z @ra[1] aa @ara[23] b @ra[1] @ara[23]';
print qq{'$s'\n};

my %found;
my %generated;
$s =~ s{ \@ ([a-z] [a-z\d_]* \[) \K (\d+) (?= \]) }
       {
            $found{"$1$2"} //=
        do {
            my $rand;
            do {$rand = int rand 9999} while exists $generated{$rand};
            $generated{$rand} = ();
            $rand;
            };
       }xmsge;

print qq{'$s'\n};
[download]

Fixed issues of producing something like this:

'xx @ra[1] y @ara[23] z @ra[1] aa @ara[23] b @ra[1] @ara[23]'
'xx @ra[1] y @ara[0] z @ra[1] aa @ara[2] b @ra[1] @ara[2]'
[download]

Comment on Re^2: Same problem replacing array index numbers Select or Download Code

Replies are listed 'Best First'.
Re^3: Same problem replacing array index numbers by AnomalousMonk (Archbishop) on Apr 11, 2012 at 21:27 UTC
... producing something like this: `'xx @ra[1] y @ara[23] z @ra[1] aa @ara[23] b @ra[1] @ara[23]'` `'xx @ra[1] y``@ara[0]` `z @ra[1] aa``@ara[2]` `b @ra[1] @ara[2]'` Good catch on the use of `//=` versus `\|\|=` in your code since the value of the generated random integer could, indeed, be zero leading to a redefinition on a subsequent encounter. I would quibble with `$generated{$rand} = ();` however, since assigning the contents of an empty list to a scalar (i.e., undef) is very odd and likely to be confusing, it is much better, IMO, to assign 1 (or any true value) since that would slightly simplify the existence test to `do { ... } while $generated{$rand};` (if, in fact, there is a requirement that the generated random integers be non-repeating).	[reply] [d/l] [select]
Re^3: Same problem replacing array index numbers by Anonymous Monk on Apr 12, 2012 at 03:49 UTC
ow.. cool.. could i also use a modified version of that to replace the array names to like a random string? i tried it myself but i cant replace with a string, only numbers...	[reply]