Re^4: reading and working with grow.out files

I made this program, but it is giving so many errors. Can you help me in debugging it.

use strict;
use warnings;
use Carp qw(croak);
{
    my $input_file = "input_file.txt";
    my @lines = slurp($input_file);
    for my $line (@lines){
        my ($filename, $ligand) = split(/\t/, $line);
        open(FILE, '<', $filename) or die "Cannot open file: $!";
        
        while (my $line = <FILE>) {
            if ($line =~ /$ligand/)
            {
            $count++;
            $first=substr($line, 0,1);
            if($first=='H');
            {
            $sum++;
            }
            }
            print "Total No. of interactions are $count";
            print " No. of Hydrogen bonds are $sum";
        }
        close(FILE);
    }   
}

##Slurps a file into a list
sub slurp {
    my ($file) = @_;
    my (@data, @data_chomped);
    open IN, "<", $file or croak "can't open $file\n";
    @data = <IN>;
    for my $line (@data){
        chomp($line);
        push (@data_chomped, $line);
    }
    close IN;
    return (@data_chomped);
}
[download]

Comment on Re^4: reading and working with grow.out files Download Code

Replies are listed 'Best First'.
Re^5: reading and working with grow.out files by marto (Cardinal) on Apr 29, 2012 at 14:10 UTC
The messages you receive tell exactly what's wrong: `Global symbol "$count" requires explicit package name at test.pl line +14. Global symbol "$first" requires explicit package name at test.pl line +15. Global symbol "$first" requires explicit package name at test.pl line +16. syntax error at test.pl line 16, near ");" Global symbol "$sum" requires explicit package name at test.pl line 18 +. Global symbol "$count" requires explicit package name at test.pl line +21. Global symbol "$sum" requires explicit package name at test.pl line 22 +.` [download] Define `$count, $first` and `$sum`, like the other variables in your script. For example, add the following line in the appropriate place: `my ($count, $first, $sum);` Next, No semi colon required here: `if ($first=='H'); {` [download] Should be: `if ($first=='H') {` [download] I suggest spending some time working on the basics: perlintro http://learn.perl.org http://perldoc.perl.org Browse the Tutorials section of this site.	[reply] [d/l] [select]
Re^6: reading and working with grow.out files by rmgzsm9 (Novice) on Apr 29, 2012 at 15:02 UTC
Thanks. It worked. Not exactly I wanted, but it worked	[reply]
Re^7: reading and working with grow.out files by marto (Cardinal) on Apr 29, 2012 at 15:12 UTC
Telling you how to fix the code you provided wasn't exactly what you wanted, or your code doesn't do what you want?	[reply]
Re^8: reading and working with grow.out files by rmgzsm9 (Novice) on Apr 29, 2012 at 16:52 UTC
Re^9: reading and working with grow.out files by marto (Cardinal) on Apr 29, 2012 at 20:05 UTC