Re: improve FTP script

Well, one thing that comes to mind is that you 'die' in a lot of places, but only unlink the lockfile on success. If you run into a transient problem and you want the script to continue running after it clears, you should probably replace die with a function that removes the lockfile then dies

fnord

Comment on Re: improve FTP script

Replies are listed 'Best First'.
Re^2: improve FTP script by asw (Initiate) on Jun 14, 2012 at 20:55 UTC
thanks for the reply. yeah, that is true re: "die". I was looking it over again, and ran into a possible problem: `if (scalar(@tmp_file_list) == 0) { die("the directory is empty!"); } else { foreach (@tmp_file_list) { if ($_ eq $lock_file) { die("Transfer_helper is busy."); } } }` [download] -- if there is are no files in the dir, the script should exit (and not write the lock file. I like the idea of creating a sub for managing the lock file. thanks	[reply] [d/l]

Replies are listed 'Best First'.

Re^2: improve FTP script
by asw (Initiate) on Jun 14, 2012 at 20:55 UTC

thanks for the reply. yeah, that is true re: "die". I was looking it over again, and ran into a possible problem:

if (scalar(@tmp_file_list) == 0) {
die("the directory is empty!");
}
else {
foreach (@tmp_file_list) {
if ($_ eq $lock_file) {
die("Transfer_helper is busy.");
}
}
}
[download]

-- if there is are no files in the dir, the script should exit (and not write the lock file.

I like the idea of creating a sub for managing the lock file. thanks

[reply]
[d/l]