welle has asked for the wisdom of the Perl Monks concerning the following question:

Dear Monks, what I am missing? I have these 2 subrutines: if I run create_file a new file is created, but I if I run it after running the subrutine open_directory_file (which reads the files stored in a directory) the other subrutine gives me errors, namely that I am trying to write on close filehandle MYFILE. Why? Thanks 

my $output_directory="TEMPORARY";

sub open_directory_file
{
print "Open files from directory...\n";
my @all_file_contents;

my $Directory = File::Spec->canonpath( $mw->chooseDirectory() );
my $shortpath = Win32::GetShortPathName( "$Directory" );
chdir($shortpath) or die "$!";

opendir (DIR, "$shortpath") or die "$!";
my @files = grep {/.*?\.txt/}  readdir DIR;
close DIR;
}

sub create_file{
open (MYFILE, ">$output_directory/token.txt");
print MYFILE "ciao";
close (MYFILE); 
}

[download]

The working subrutine open_directory_file (thanks roboticus for the hint!) 


my $output_directory="TEMPORARY";

sub open_directory_file
{
print "Open files from directory...\n";
my @all_file_contents;

#added following line
my $pwd = cwd();

my $Directory = File::Spec->canonpath( $mw->chooseDirectory() );
my $shortpath = Win32::GetShortPathName( "$Directory" );
chdir($shortpath) or die "$!";

opendir (DIR, "$shortpath") or die "$!";
my @files = grep {/.*?\.txt/}  readdir DIR;
close DIR;

#added following line
#go back to original directory
chdir($pwd);
}

[download]

Replies are listed 'Best First'.
Re: TK filehandle path
by roboticus (Chancellor) on Jul 09, 2012 at 16:40 UTC

    welle:

    Since you're changing the current directory in open_directory_file(), the output directory is no longer where you think it is, relative to your current directory.

    ...roboticus

    When your only tool is a hammer, all problems look like your thumb.

[reply]
[d/l]

      Thank you! You brought me to the right "path" ;)

      I have updated a working solution.

[reply]
Re: TK filehandle path
by zentara (Cardinal) on Jul 09, 2012 at 16:51 UTC
    I don't have Win32, so I can't get shortpath, but I suspect it's because you chdir, and that path to file is no longer there.

    Also, when you create_file() you should check the open 

    sub create_file{
open (MYFILE, ">$output_directory/token.txt") or die "$!\n";
print MYFILE "ciao";
close (MYFILE); 
}

    [download]

    I get "no such file or directory". It would also help if you made a self-contained fully running example.

    I'm not really a human, but I play one on earth.
    Old Perl Programmer Haiku ................... flash japh
[reply]
[d/l]

Back to Seekers of Perl Wisdom