in reply to Re^3: Manipulating data structure
in thread Manipulating data structure

Hej Sundialsvc4 and thanks for your post,

I've done some changes in this subroutine so it looks like this now:

my @entries; my $previouskey = ""; open (KOF, "<$konfil") or die "Kan inte \xF6ppna filen $konfil"; open (NYF, ">$nyfil") or die "Kan inte \xF6ppna filen $nyfil"; flock (NYF,2) or die $!; my $offset = 0; while(<KOF>) { chomp; $value =~ s/^\s*(\S*)\s+$/$1/; if ($key =~ /^(.*)(\d+)$/) { ##### #### #### $key = $1; # # # # # # $entries[$2]{$key} = $value; ##### # # # # next; # # # # # # } # # #### #### unless ($key eq $previouskey || $previouskey eq "") { $offset = 0; } $previouskey = $key; $entries[$offset]{$key} = $value; $offset++; } my @sorted = sort { $a->{'NYTT'} <=> $b->{'NYTT'} } @entries; my $pers =0; foreach my $e (@sorted) { print NYF ($e->{'UID'}, "|", $e->{'FNA'}, "|", $e->{'ENA'}, "|", $ +e->{'PRE'}, "|", $e->{'NYTT'}, "|", $e->{"PRI"}, "|", $e->{"FOR"}, "| +", $e->{"CMG"}, "|", $e->{"MEX"}, "\n") if( $e->{"UID"} ne "" || $e-> +{"FNA"} ne "" || $e->{"ENA"} ne ""); $pers++ if ($e->{"UID"} ne ""); } close KOF; close NYF;
and it seems to work !

Thanks for pointing me to the right direction

Replies are listed 'Best First'.
Re^5: Manipulating data structure
by Cristoforo (Curate) on Aug 17, 2012 at 15:14 UTC
    Hi SerZKO

    this line: if ($key =~ /^(.*)(\d+)$/) should be if ($key =~ /^(.*?)(\d+)$/)

    The reason you need the '?' there is that perl regexes are greedy. In your code (.*) consumes every character in $key and then fails to match any digits for the second group, (\d+). Then the regular expression engine will back up 1 character to try to make the match succeed. And it will, capturing the last char which is a digit. But what if your digits are more than 1 char? Your code would fail to capture all the digits since the regex was satisfied with only one of them.

    The question mark makes the regex look to see if the next char is a digit, and if so, start capturing in the second group.

    Chris

      Hej Chris,

      Thanks for pointing this out !