Re^2: if,if and again,if

Data-driven approaches FTW!

Though I'd be tempted to do things a bit more perlishly (at least for my own definition of perlish):

my @matchers = (
  [ qr/(Lz0|PLATO)/i => 'Apps' ],
  ...
);
for my $check (@matchers) {
  if ($release_name =~ $check->[0]) {
    $category = $check->[1];
    print "[INFO] Category: $category\n";
    last;
  }
}
[download]

Actually, a bit more perlish, IMO, would be to replace that for loop altogether:

use List::Util qw(first);
my $category = map {
  $_ ? $_->[1] : undef;
} first {
  $release_name =~ $_->[0];
} @matchers;
if ($category)
{
  print "[INFO] Category: $category\n";
}
else
{
  print "[ERROR] Unrecognised release type: $release_name\n";
}
[download]

But maybe that's just me. :-)

Comment on Re^2: if,if and again,if Select or Download Code

Replies are listed 'Best First'.
Re^3: if,if and again,if by moritz (Cardinal) on Aug 23, 2012 at 18:04 UTC
If we go all perlish, I'd get rid of the ugly map with a ternary :-). Either `my $category = first { ... } ... ; if ($category) { $category = $category->[1]; print "[INFO] Category: $category\n"; }` [download] Or if you insist on a map on a one-element list, write it as `map $_->[1], grep $_, first { .... } ...;` [download] IMHO several simple operations are easier to read than a few complicated ones. Perl 6 - the future is here, just unevenly distributed	[reply] [d/l] [select]

Replies are listed 'Best First'.

Re^3: if,if and again,if
by moritz (Cardinal) on Aug 23, 2012 at 18:04 UTC

If we go all perlish, I'd get rid of the ugly map with a ternary :-). Either

my $category = first { ... } ... ;
if ($category) {
    $category = $category->[1];
    print "[INFO] Category: $category\n";
}
[download]

Or if you insist on a map on a one-element list, write it as

map $_->[1],
grep $_,
first { .... } ...;
[download]

IMHO several simple operations are easier to read than a few complicated ones.

Perl 6 - the future is here, just unevenly distributed

[reply]
[d/l]
[select]