in reply to passing arguments to subroutine

You don't need to chomp. If you printed the variable out you would see it is so. You will also need to interpolate $i/controlpanel in a string context.

I would rewrite the copying code as follows:

  mkdir $i/controlpanel/ unless -d "$i/controlpanel";
  system 'cp', '-fRp', $dir, $i" and die "cp went boom ($?).\n";

[download]

When oh when will people check for system errors?

shift is as good a way as any for reading the arguments passed to a routine.

update: hmm, the fact that the mkdir call is not checked is left as an exercise to the reader (it also needs a protection mask à la 0500).

--
g r i n d e r

Replies are listed 'Best First'.
Re: Re: passing arguments to subroutine
by c (Hermit) on Jul 23, 2001 at 22:38 UTC
    More than one mistake in that code. I'd like to say that I left that mkdir check out because the code is still in the beginning stages, but I like to think of myself as an honest guy.

    mkdir("$i/controlpanel", 0755) or die "Problems making dir : $!\n" unl
+ess ( -d "$i/controlpanel" );
system("cp -fRp $dir/controlpanel") or die "Problems copying dir : $!\
+n";

    [download]

    better?

    humbly -c

[reply]
[d/l]

      All the more reason for you to check your mkdir if the code is in it's beginning stages. You want to throw all the sanity checking devices that you can think of in your code (especially beta code).

      redmist
      Silicon Cowboy
[reply]
[d/l]
      Change: 
      system("cp -fRp $dir/controlpanel") or die "Problems copying dir : $!\
+n";

      [download]
      To: 
      system("cp -fRp $dir/controlpanel") == 0 or die "Problems copying dir 
+: $!\n";

      [download]
      system returns the exit status of the program being run, and the programs conventionally return 0 (zero) on success.
[reply]
[d/l]
[select]

In Section Seekers of Perl Wisdom