such a simple question about file uploads... but its killing me!!

tomgracey has asked for the wisdom of the Perl Monks concerning the following question:

Please please please someone put me out of my misery! There must be something (extremely!) simple I am forgetting/doing wrong as I have tried this on several setups and I get the same result. Here is my HTML:

<!DOCTYPE HTML><html><body>

Or upload a new file<br><br>
<form id = 'email-upload-form' name='email-upload-form' action='/cgi-b
+in/testform/upload.pl' method='POST'>
<input type = 'file' name='emailupload' enctype="multipart/form-data"/
+><button name='submit-button' id='upload-button' type='submit'>upload
+</button>
</form>

</body>
</html>
[download]

and my perl script to pick up the file:

#!/usr/bin/perl

use strict;
use CGI;
use CGI::Carp qw(fatalsToBrowser);
my $query = new CGI();

print "Content-type: text/html\n\n";

my @params = $query->param;

print "params are @params<br>\n";

my $fh = $query->upload('emailupload');
print "fh contains $fh and is a ".ref(\$fh)."<br>\n";
print "fh is not defined!" if(!defined($fh));

print "$_\n" while(<$fh>);
[download]

The output of which, when I try to upload a dummy text file is

params are emailupload submit-button
fh contains and is a SCALAR
fh is not defined!
[download]

In fact it does exactly the same thing if I hit 'upload' without first selecting a file.

BTW I read that doing operations on $fh other than file handle operations results in it losing its 'magic' and becoming a scalar - however even if I have

#!/usr/bin/perl

use strict;
use CGI;
use CGI::Carp qw(fatalsToBrowser);
my $query = new CGI();

print "Content-type: text/html\n\n";

my $fh = $query->upload('emailupload');

print "$_\n" while(<$fh>);
[download]

I still get no output... I know I'm going to kick myself when I finally find out but.. can anyone identify what excruciating silly thing I am (not) doing?

Comment on such a simple question about file uploads... but its killing me!! Select or Download Code

Replies are listed 'Best First'.
Re: such a simple question about file uploads... but its killing me!! by tobyink (Canon) on Sep 12, 2012 at 08:25 UTC
The `enctype` attribute needs to be on the `<form>` element, not the `<input>` element. `perl -E'sub Monkey::do{say$_,for@_,do{($monkey=[caller(0)]->[3])=~s{::}{ }and$monkey}}"Monkey say"->Monkey::do'`	[reply] [d/l] [select]
Re^2: such a simple question about file uploads... but its killing me!! by tomgracey (Scribe) on Sep 12, 2012 at 09:12 UTC
Arrgh... I knew I was going to want to shoot myself when I found out! Thanks though!	[reply]
Re: such a simple question about file uploads... but its killing me!! by Anonymous Monk on Sep 12, 2012 at 08:30 UTC
See CGI#PROCESSING_A_FILE_UPLOAD_FIELD/Handling interrupted file uploads and check cgi_error()	[reply]
Re: such a simple question about file uploads... but its killing me!! by Anonymous Monk on Sep 12, 2012 at 08:25 UTC
I can't tell without trying to run this code, but I notice your form has no enctype `$ perl -MCGI -le " print CGI->start_form <form method="post" action="http://localhost" enctype="multipart/form- +data">` [download] Might be mportant , might not	[reply] [d/l]