Re^2: Another Pattern Matching Question

Sorry about not using the

.

Here's my code when I actually hard code the '7R', yet it still fails.
+  I must be missing something else? <br>


<code> my ($product, $year, $month, $day, $hour, $suffix, $ver ) = spl
+it /\./, $fileName;

# test file name--naming convention is '<product>.<year>.<month>.<day>
+.<hour>.bin' 

if ($fileName =~ /3B4[0|1|2]RT\.\d{10}\.\7R\.bin/) { 
   ($product, $year, $month, $day, $hour, $ver) = 
      ($fileName =~ /(3B4.RT)\.(\d{4})(\d\d)(\d\d)(\d\d)\.(7R\)\.bin/)
+;
      $version = sprintf "%03d", $ver; # a little confusing, $version 
+is global
                                       # $ver is local
}
elsif ($fileName =~ /3B4\dRT\.\d\d\d\d\.\d\d\.\d\d.\d\dz\.bin/) {
    ($product, $year, $month, $day, $hour, $suffix) = split /\./, $fil
+eName;
}
else {
    print STDERR "($0,$$) ERROR:  invalid file name--'$fileName'\n" if
+ $opt_v;
    exit 2;
}
[download]

Comment on Re^2: Another Pattern Matching Question Download Code

Replies are listed 'Best First'.
Re^3: Another Pattern Matching Question by kcott (Archbishop) on Oct 12, 2012 at 19:27 UTC
Your solution which adds `R?` to the original regex was on the right track and achieves what you want, albeit poorly: `$ perl -Mstrict -Mwarnings -E 'my $fileName; my $re = qr{3B4[0\|1\|2]RT\.\d{10}\.\d+R?\.bin}; $fileName = "3B40RT.2000033121.7.bin.gz"; say +($fileName =~ /$re/) ? "match" : "no match"; $fileName = "3B40RT.2000033121.7R.bin.gz"; say +($fileName =~ /$re/) ? "match" : "no match"; ' match match` [download] I don't think you understand character classes or alternation (perhaps both). Where you're trying to match a 0, 1 or 2 in the same position, `[0-2]` would be far better than `[0\|1\|2]` (which is trying to match a 0, pipe, 1, pipe or 2 in the same position) - the 2nd pipe is redundant and the 1st pipe isn't wanted anyway. So, here's an improved version: `$ perl -Mstrict -Mwarnings -E 'my $fileName; my $re = qr{3B4[0-2]RT\.\d{10}\.\d+R?\.bin}; $fileName = "3B40RT.2000033121.7.bin.gz"; say +($fileName =~ /$re/) ? "match" : "no match"; $fileName = "3B40RT.2000033121.7R.bin.gz"; say +($fileName =~ /$re/) ? "match" : "no match"; ' match match` [download] Recommended reading: perlrequick - Perl regular expressions quick start perlretut - Perl regular expressions tutorial perlre - Perl regular expressions, the rest of the story Writeup Formatting Tips -- Ken	[reply] [d/l] [select]
Re^3: Another Pattern Matching Question by surib (Initiate) on Oct 12, 2012 at 17:43 UTC
Or like this: (I've tried so many combinations I'm confusing myself!) `if ($fileName =~ /3B4[0\|1\|2]RT\.\d{10}\.7R.bin/) { ($product, $year, $month, $day, $hour, $ver) = ($fileName =~ /(3B4.RT)\.(\d{4})(\d\d)(\d\d)(\d\d)\.(7R)\.bin/); $version = sprintf "%03d", $ver; # a little confusing, $version +is global # $ver is local` [download]	[reply] [d/l]
Re^4: Another Pattern Matching Question by runrig (Abbot) on Oct 12, 2012 at 17:50 UTC
If you just want to match 0,1, or 2 and not "\|", then your character class should be `[012]`, not `[0\|1\|2]`.	[reply] [d/l] [select]