I've been wondering if the method below is terribly inefficient or if there is a better way to do the same thing. I'm using this method to return the results of a select statement to object attributes which can then latter be accessed. I'm thinking that this may be a bit of a memory hog, but the convenience is nice. Just looking for some thoughts and ideas on this.
Thanks
sub select {
    my $s       = shift;
    my $sql     = shift;
    my $sth = $s->dbh->prepare( $sql ) ||    
        $s->write_log("Can't prepare select ($sql): ".$s->dbh->errstr)
+;
    $sth->execute() ||
        $s->write_log("Can't execute select ($sql): ".$sth->errstr);
    $s->fields  = $sth->{NAME};    
    my $x = 0;
    my @ar = ();
    while ( my $hr = $sth->fetchrow_hashref() ) {
        $ar[$x++] = $hr;
    }
    $s->rows = $x;     
    $s->ar   = \@ar;   
    $sth->finish();
}

[download]

In reply to RE: References of Eternal Peril (while we're on the subject) by steveAZ98
in thread References of Eternal Peril by mwp

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.