I'd use a hash to manage the colour/replacement pairs. Consider:

use strict; use warnings; my %colours = ( 'baby blue' => 'BB', 'baby pink' => 'BP', 'dark blue' => 'DB', 'dark purple' => 'DP', 'hot pink' => 'HP', 'light purple' => 'LP', 'pink' => 'PK', 'pinkish' => 'PI', ); my $colourMatch = join '|', sort {length $b <=> length $a || $a cmp $b} keys %colours; for my $colour ('baby blue', 'baby pink', 'baby green', 'pink', 'pinki +sh') { if ($colour =~ /($colourMatch)/) { print "Matched $colour: $colours{$1}\n"; } else { print "Unmatched: $colour\n"; } }

Prints:

Matched baby blue: BB Matched baby pink: BP Unmatched: baby green Matched pink: PK Matched pinkish: PI

Note that the sort is there so that pinkish is matched correctly rather then being matched by 'pink'. Depending on the order of your tests and the strings being tested you current code would suffer from the same problem.

True laziness is hard work

In reply to Re: If statement not working by GrandFather
in thread If statement not working by perlnoobster

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.