Should work, if $upload is a good file handle. How are you getting $upload? Post more code! It's free, don't be shy!

BTW, you can surround any code you post with <code> tags which make it easier to read, preserve your indenting etc.

§ George Sherston