in reply to Re: Re^3: my, my, my
in thread my, my, my

I thought of that layout but don't like it. Much too verbose, and the nested ternaries are supposed to look like a switch construct.

I didn't think of return unless for some reason. There's no real difference. I'm pretty sure (without deparsing to verify right now), that the unless form compiles to the or form, internally, and I like it because the return is not the expected path - but it requires an extra pair of noisy parens, so the jury's out on that one too. :)

(You can tell I spend a fair bit of time pondering style questions..)

Makeshifts last the longest.

Replies are listed 'Best First'.
Re: Re^5: my, my, my
by BrowserUk (Patriarch) on Nov 16, 2002 at 15:21 UTC

    (You can tell I spend a fair bit of time pondering style questions..)

    I think that good layout of code does more to than just aid readability and simplify maintanence. I often find that if I'm having trouble laying a piece of code in an eye-pleasing manner, its indicative of deeper trouble.

    I really have found down the years that elegant code is usually right and inelegant code is often wrong. Nothing hard and fast, just a rule of thumb.

    Having spent a while longer futzing with the return statement (it's a boring wet Saturday in the UK), I think I'd settle for: 

    return          if !@node;  
return ($o, @n) if $nodes_only;
return  map { ( $n->value('divname'), $n->value('siebel_id') ) } @n;

    [download]

    Okay you lot, get your wings on the left, halos on the right. It's one size fits all, and "No!", you can't have a different color.
    Pick up your cloud down the end and "Yes" if you get allocated a grey one they are a bit damp under foot, but someone has to get them.
    Get used to the wings fast cos its an 8 hour day...unless the Govenor calls for a cyclone or hurricane, in which case 16 hour shifts are mandatory.
    Just be grateful that you arrived just as the tornado season finished. Them buggers are real work.

[reply]
[d/l]

In Section Meditations