Hidden DL Code link

I'm not sure when this changed, but (using the default theme) it seems like the CSS/font tags arround the "Download Code" links seem to be making it invisible

I'm using Mozilla/1.3, and what i'm noticing is that this...

<a href="/index.pl?parent=303872&amp;title=GD%20newbee%20question&amp;
+lastnode_id=303872&amp;displaytype=display&amp;type=superdoc&amp;node
+=Comment%20on"><font color="white">comment on GD newbee question</fon
+t></a>
[download]

...renders fine, but this...

<font color="white"><br><a href="/index.pl?node_id=303872&amp;displayt
+ype=displaycode"><font size="-1">Download Code</font></a></font>
[download]

...doesn't.

I believe it's because in the case of the "comment" link, the white font tag is binding more tightly then the CSS for the anchor tag. With the "DL" link, the anchor tag is binding more tightly. (And as you probably know: the CSS for the default theme says that anchor links should be the same color blue as the table border/headers

It seems like a simple fix to move the font tag inside the anchor tag (just like the comments link). Alternately, lose the font tags altogether, and make a new CSS class links in table headers.

Comment on Hidden DL Code link Select or Download Code

Replies are listed 'Best First'.

Re: Hidden DL Code link
by theorbtwo (Prior) on Nov 02, 2003 at 09:16 UTC

This bug is (was) my fault. I wrote a patch so that replies now get a "d/l code" link, as suggested by liz. However, that patch contained a slight bug, that escaped testing, because my test setup has a black-background theme. The bug should be fixed now -- in a manner quite similar to what you suggested.

Many thanks to petruchio for applying my patches -- both the one introducing the feature, and the two fixing the bug you noticed.

(While I'm at it, there should also be a slightly more helpful message for duplicates. The change doesn't make duplicate detection any more reliable, though, it just makes the message indicate what message you duplicated. Making the duplicate detection more reliable is still on at least two TODO lists. As always, there is no ETA.)

Warning: Unless otherwise stated, code is untested. Do not use without understanding. Code is posted in the hopes it is useful, but without warranty. All copyrights are relinquished into the public domain unless otherwise stated. I am not an angel. I am capable of error, and err on a fairly regular basis. If I made a mistake, please let me know (such as by replying to this node).

[reply]

Re: Hidden DL Code link
by PodMaster (Abbot) on Nov 02, 2003 at 08:32 UTC

MJD says "you can't just make shit up and expect the computer to know what you mean, retardo!"
I run a Win32 PPM repository for perl 5.6.x and 5.8.x -- I take requests (README).
** The third rule of perl club is a statement of fact: pod is sexy.

[reply]