1. Generally, I like to deal with my error conditions before dealing with my success conditions. Something like:

   sub getHostname
   {
       my ($IpAddress) = @_;
   
       unless ($pingObj->ping($IpAddress, 1))
       {
           print "No response from $IpAddress\n" if $VERBOSE;
           return;
       }
   
       # Do the rest of the stuff here
   }
   [download]

2. As for your variables, maybe something like:

       # This is the rest of the stuff.
   
       # Note the use of single quotes. It's not a performance thing - it
   +'s a
       # readability thing. Double-quotes are for interpolation. Single-q
   +uotes
       # tell the reader there's no interpolation here.
       my $Host = uc(gethostbyaddr (inet_aton($IpAddress), AF_INET))
           or '[FAILED]';
   
       # Get rid of everything starting with -UDP.
       # In your version, you captured everything before -UDP. Same diffe
   +rence.
       $Host =~ s/-UDP.*//;
       $Host = "${IpAddress}[NULL]" if $Host eq '';
   
       print "$IpAddress\t$Host\n" if $VERBOSE;
       return $Host;
   }
   [download]

3. As for threading issues, I'm definitely not the one to ask about that. You'll probably have to add lock() somewheres.

It works fine in threads I am just trying to have less variables, so that overall I am carrying less baggage in the threads.

Though I must agree I like unless more than if, but after so many years using if exlusively I don't intially think of using unless. This is a thought process I must try to change.

The regex change is much better thank you. It goes to show when you put code together to get it to work, that bits can grow and you should learn to trust the gut instinct that you need to revisit a section again. This bit of code intially just got the host name but over the time of looking at the output we added more to it. And I kept feeling it needed a revisit. But when I would look at it I saw how it worked and why we did it that way and couldn't think out of the box we built.

Thank you again.

Update:
I modified the regex in my code for to look like this:


$Host =~ s/(-UDP.*|\..*)//;
[download]


Which seems to be testing fine but still need to throw it some weird machine names to be sure.
"No matter where you go, there you are." BB

use Net::DNS;
my $res   = Net::DNS::Resolver->new;
my $query = $res->search("host.example.com");
  
if ($query) {
    foreach my $rr ($query->answer) {
        next unless $rr->type eq "A";
        print $rr->address, "\n";
    }
} else {
    warn "query failed: ", $res->errorstring, "\n";
}
[download]

L-LL-L--L-LL-L--L-LL-L--
-R--R-RR-R--R-RR-R--R-RR
B--B--B--B--B--B--B--B--
H---H---H---H---H---H---
(the triplet paradiddle with high-hat)

I am on a Win32 machine for now. And Net::DNS is a bit buggy on Win32 from the link you sent. But to explain it more clearly. I have a range of IP addresses that are pinged to see what live machines are on the network. I then look up from a live ip the host name. I need to get the computer name from computer_name.company.com but sometimes our dns/dhcp systems resolves to a name of computer_name-udp12345678.company.com

"No matter where you go, there you are." BB

if ($pingObj->ping($IpAddress, 1)){
   my $MachineName = uc(gethostbyaddr (inet_aton($IpAddress), AF_INET)
+) or "[FAILED]";
   $MachineName = ($MachineName =~ /^(.*?)(-UDP\w*)?\./i)[0];
   print "$IpAddress\t$MachineName" if $VERBOSE;
} else {
   print "$IpAddress\tNo Response\n" if $VERBOSE;
}
[download]

   # Assuming you won't have a machine named "0"
   $MachineName = ($MachineName =~ /^(.*?)(-UDP\w*)?\./i)[0] || ($IpAd
+dress . '[NULL]');
[download]

Oddly enough the code supplies catches .company.com look ups we found. I was getting blank input and caught it with that. I am sure I meant $Host eq '' but the code I cut and paste worked. Though it may have been off the edit version I was working on to change the regex. When I get back to work I will look at the in production code versus the new version I was working on. I believe we tried a regex like you supplied but the problem is their is a value in the string with a value of .company.com but after the regex that is reduced to '' and it was a catch at the bottom.

Besides catching this in the script I need to know than how to fix these machines that have a null computer name, but that is another query for another place.

"No matter where you go, there you are." BB