Re: Perl dbi disconnect question...

First you have to answer the question "what do i want to have happend when an error occurs during X?" Then you can decide where to do what.

Regarding your connection line:

$dbh->connect(assuming_relevant_connection_params_are_here);
[download]

make sure that you set RaiseError to true and you could even 'attach' your bail_out sub as well:

my $dbh = DBI->connect(
   'DBI:driver:database:host', 'user', 'pass',
   {RaiseError => 1, HandleError => \&bail_out},
);
[download]

Now, when an error occurs, your sub will called automatically. Give that a shot and see what happens.

jeffa

L-LL-L--L-LL-L--L-LL-L--
-R--R-RR-R--R-RR-R--R-RR
B--B--B--B--B--B--B--B--
H---H---H---H---H---H---
(the triplet paradiddle with high-hat)

Comment on Re: Perl dbi disconnect question... Select or Download Code

Replies are listed 'Best First'.
Re: Re: Perl dbi disconnect question... by kiat (Vicar) on Jan 05, 2004 at 01:17 UTC
I need a little clarification below: `my $dbh = DBI->connect( 'DBI:driver:database:host', 'user', 'pass', {RaiseError => 1, HandleError => \&bail_out}, );` [download] With the settings above, does it mean that I don't need a 'or' to catch a failed query. See code below: `my $dbh = DBI->connect( 'DBI:driver:database:host', 'user', 'pass', {RaiseError => 1, HandleError => \&bail_out}, ); my $sql = qq{ SELECT COUNT(*) FROM profiles WHERE username=? }; # Original #my $result = $sth->execute($username) # or bail_out('Error executing SELECT'); # Modified # Note that 'or' clause is removed my $result = $sth->execute($username); $dbh->disconnect;` [download] Relatedly, do I need to explicitly call disconnect within bail_out with your settings (i.e. RaiseError => 1 and HandleError => \&bail_out)? That is: `sub bail_out { my $dbh = shift; $dbh->disconnect or bail_out(msg => "Cannot disconnect from the database"); # prints html message exit(0); }` [download] Thanks for your great help :)	[reply] [d/l] [select]
3Re: Perl dbi disconnect question... by jeffa (Bishop) on Jan 05, 2004 at 15:55 UTC
That's right, bail_out will called for you. As for disconnect ... i don't explicitly call it unless i absolutely have to. As noted other replies to this question, you really don't have to. You definetly do not want to call bail_out itside of itself. As always, refer to the manual when in doubt: (just search for `HandleError`) `use Carp; ... sub bail_out { my $message = shift; confess ($message); }` [download] Should do the trick for now ... oh, don't worry about passing the message argument when you call bail_out, because you don't even have to call bail_out (but you still can if you need to). Also ... do you really need handle the errors? Have you tried letting DBI do it for you? Just specify RaiseError without any HandleError subroutine ... And you are always welcome. :) jeffa L-LL-L--L-LL-L--L-LL-L-- -R--R-RR-R--R-RR-R--R-RR B--B--B--B--B--B--B--B-- H---H---H---H---H---H--- (the triplet paradiddle with high-hat)	[reply] [d/l]