Thank you very much for your feedback.

The effect of placeholder and caching was new to me but makes sense.
I will take a closer look at that hoping that speedycgi already does something there for I still fear the use of mod_perl with my code.

For the security issue you are right in general but in this case I think there is no risk because only INT requests from the product data find their way to this subroutine. Nevertheless I will clean up my stuff with placeholders which seem to be better in any way.

I will also rethink the logic in this operation. The big but is that I do have categories of images (single, item in use, primary) and several sources for images where one can have one or more categories of images. I want to display the image group with the highest priority for every category and discard the rest. If a product is edited by staff I still want to access all available images which could result in an editorial pick for every image category. A small part of the idea is the following:

AAB (product in use) could be two images from source with Priority 5
EBD (single product image) could be three images which shows the product from different views
PRI (primary image) if not defined the first image from EBD should be taken

I start do doubt what I am doing is clever even with prices where I originally thought the way is obvious:

sub get_Price {
    my $SupplierID = shift;
    my $SupplierPID = shift;
    # tax type 0,1,2 which could be different
    # depending on the country of the shop
    my $Tax = shift;
    
    # could be e.g. buying price or selling price
    my $Price_Type = shift;
    
    #if the request comes from a basket with amount in basket
    my $amount = shift || 0;
    
    #clientID is the shop/market
    my $ClientID = $STASH{ClientID};
    my $return;
    my $cond = GX::SQL::Condition->new();
    $cond->add("ClientID",'=',$ClientID);
    my $customer_cond = GX::SQL::Condition->new();
    
    # customerID 10000 is a dummy for public prices
    $customer_cond->add("CustomerID",'=',10000);
    
    # if there are individual prices they are also considered
    $customer_cond->add("CustomerID",'=',$STASH{account}->{ID})
      if $STASH{account}->{ID};
    
    $customer_cond->bool('OR');
    $cond->add($customer_cond);
    $cond->add("SupplierID",'=',$SupplierID);
    $cond->add("SupplierPID",'=',$SupplierPID);
    $cond->add("Price_Type",'=',$Price_Type);
    $cond->bool('AND');
    
    my @prices;
    my $previous_price;
    
    my $udx_prices = $DB->table('UDX_Prices');
    $udx_prices->select_options ("ORDER BY Amount ASC, Price ASC");
    my $sth = $udx_prices->select(['
        Price_Type,
        Amount,
        Price,
        Discount,
        Rebate,
        Currency,
        Price_Quantity'], $cond);
        
    while (my $_ = $sth->fetchrow_hashref) {
        #calculate customer discount in percent if available
        $_->{Price_Discount} = sprintf("%0.2f", ($_->{Price} *
          ( $STASH{account}->{Discount} ) / 100));
        $_->{Price} = sprintf("%0.2f", ($_->{Price} -
          $_->{Price_Discount} ));

        my ($new_price,$old_price);
        $old_price = $_->{Price} * 100 / $_->{Price_Quantity};
        $_->{Price} = sprintf("%0.2f", ($_->{Price}) /
          $_->{Price_Quantity});

        $new_price = $_->{Price} * 100;
        if ($old_price == $new_price) {
            $_->{Price_Quantity} = 1;
        }
        else {
            $_->{Price} = sprintf("%0.2f", ($old_price / 100));
        }
        
        # if the previous price is smaller skip the price
        if ($previous_price->{Price} &&
          $previous_price->{Price} <= $_->{Price}) {
            next;
        }
        
        # if the amount is the same as before skip the price
        next if $previous_price->{Amount} == $_->{Amount};
        $_->{Tax} = $STASH{shop}->{'Local_Tax' . $Tax};
        $_->{Gross_Price} = sprintf("%0.2f", ($_->{Price} *
          (100 + $STASH{shop}->{'Local_Tax' . $Tax}) / 100));
        $_->{Tara} = 
          sprintf("%0.2f", ($_->{Gross_Price} - $_->{Price}));

        $previous_price = $_;
        push @prices, $_;
    }
    $return->{prices} = \@prices;
    return $return;
}

[download]

I order the prices by amount and price. If an amount equals the previous amount the price will be skipped and if a price is higher than the prevoius price it will be skipped either. First could occur based on rounding and calculation, the second should not happen but gives me some kind of security.

As said, I am happy for your input because it makes me question myself and brings up new ideas for me.

Cheers derion

In reply to Re^4: performance with mysql / file-caching / hash reference on demand by derion
in thread performance with mysql / file-caching / hash reference on demand by derion

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.