I think you can greatly simplify expand_ports. 
# Warning: untested...

sub expand_ports {
    my $port = shift;
    my %ports;
    foreach my $range (split /\s*,\s*/, $port) {
        if ($range =~ /^\d+$/) {
            $ports{$range}++;
        } elsif ($range =~ /^\s*(\d+)\s*-\s*(\d+)\s*$/) {
            @ports{$1..$2} = ($1..$2);
        } else {
            die "Bad port spec";
        }
    }
    return sort keys %ports;
}

[download]

split() doesn't care very much if there aren't any commas, so you don't need to treat the "no commas" cases as special cases. Storing the found ports as hash keys implicitly removes duplicates. In my example I don't care about the values at all, so I just use the most convenient method of setting the hash keys to any old value in each case.

I'm sure someone will find some typos or minor syntax errors there, I just wanted to get the general idea across :) I hope this helps.

Alan

In reply to Re: Suggestions & Improvements by ferrency
in thread Suggestions & Improvements on a portscanner using IO::Socket by czarfred

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.