Saftey warning: You're passing $fullfile through the shell, potentialy doing all sorts of bad things.
eval 'my ($pid) = fork; if ($pid == 0) { exec "display -title %d/%f $fullfile" }';
Consider $fullfile='; rm -rf /', or 'realfilename > ~/irreplacable.file', or even '</dev/urandom'.
Unless your input data file is implicitly trusted, you should be carefuly filtering it. Even if it is, you should be using the array form of exec -- exec(qw(display -title %d/%f), $fullfile).
Even then, consider what arguments display takes -- you should probably filter for filenames starting with a dash, or use a -- end-of-arguments marker, if display supports it.
Oh, and there's no reason to use stringy eval here; BLOCK eval will work just as well, and is much more efficent. (Stringy eval will recompile the argument every time.)
Warning: Unless otherwise stated, code is untested. Do not use without understanding. Code is posted in the hopes it is useful, but without warranty. All copyrights are relinquished into the public domain unless otherwise stated. I am not an angel. I am capable of error, and err on a fairly regular basis. If I made a mistake, please let me know (such as by responing to this node).
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.