That's simple enough, I don't see where it could fail. It's possible to shorten things slightly, at least when skipping comments or whitespace:
sub readConfigData { my $filename = shift; # name of the config file. my %settings; open( DATAFILE, "< $filename" ) or die "Can't Open $filename; reason: $!\n"; while ( <DATAFILE> ) { next unless /\S/; # skip lines of only whitespace next if /^\s*#/; # skip comments s/^\s+|\s+$//g; # trim whitespace in place my ( $cfglabel, $cfgvalue ) = split( /\s*=\s*/, $_, 2 ); $settings{$cfglabel} = $cfgvalue; } close( DATAFILE ) or die "Can't Close $filename; reason: $!\n"; return %settings; }
Not only is it shorter, it's slightly more efficient. Additionally, the split will remove whitespace from after the key and before the value. It even now allows the value to contain an equal sign.

Very Early Update: dws pointed out that I had forgotten a slash. See if you can figure out where!


In reply to Re: Simple Configuration Parser by chromatic
in thread Simple Configuration Parser by footpad

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.