comment on

You are using a global variable $decimal in sub convb2d. It would be cleaner to pass that value as an argument to the routine, such as

convb2d($decimal);
sub convb2d {
    my $decimal = unpack 
( "N", pack("B32", substr("0" x 32 . $_[0], -32 )));
print ("Decimal: $decimal\n");
exit;
}
[download]

The naming of your routine, sub convb2d would imply to me that it was going to perform a conversion. However, it actually does the conversion, prints the result, and then exits the program. I would have the routine instead simply perform the conversion, and return the result. Imagine future uses -- would this routine be useful if you then wanted to sum up a group of binary numbers in decimal? It wouldn't... but if you did...
```
$decimal = convb2d($decimal);
sub convb2d {
    return unpack 
( "N", pack("B32", substr("0" x 32 . $_[0], -32 )));
}
[download]
```
You no longer need the extra variable and can now use this function in many more ways.
You don't need '()' around print strings.
The previous authors suggestion regarding the regular expression is very good as well.

In reply to Re: perl do's and don'ts by Sifmole
in thread perl do's and don'ts by Anonymous Monk

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		`&`
	<		`<`
	>		`>`
	[		`[`
	]		`]`

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.