I'm pretty sure that the problem is line 10 of createscratchpad (link only works for members of pmdev). The problem looks fairly easy to fix, but I'll leave that for others at this point. The problem goes away once all scratchpads are converted anyway and it isn't a serious problem.

The problem looks fairly easy to fix, but I'll leave that for others at this point.

Im totally flummoxed by this. The scratch pads are named "$user\'s scratchpad" so linking to a node by that name should take one to the scratchpad. So I don't understand what the problem is that needs fixing. Otherwise id be happy to take care of it.



---
demerphq


First they ignore you, then they laugh at you, then they fight you, then you win.
-- Gandhi

Line 10 is:

$query->param('node', "$user\'s scratchpad");
[download]

which changes a global which changes what page the user gets sent to not based on what page the user wanted to go to. Save and restore the value of this parameter so that after this code is run the CGI parameters are as the user requested.

Perhaps a worse problem is that we have tons of never-used user pages and the way scratchpads were implemented means that any time anyone visits one of these pages a blank and useless scratchpad is created. It'd be wise to avoid creating a node for any scratchpad that is empty (but don't delete a scratchpad node just because it is empty).

- tye