comment on

Hello Monkish gentlemen, Hope it is a serene time to look at a new problem and help a brother out. I have developed a phone contacts book, and here are the details.

Firstly, my program consists of a HTML file and a CGI file. The HTML form basically has two fields : one for Adding Contact , second for Searching contact using first&last names.

In case of Search submit, it prints the contact information, and displays two new submit buttons Update & Delete in a new form. Here is the problem:

In the Deletecontact() function, if I change the parameter $lname1 to a fixed value for testing, the sql works. It somehow isn't passing $lname1 on updating the CGI page with submit button. Same goes for Update() function.

Secondly with Update() function as I try to show the default values in the textfields of the new input form, it is only displaying the variable names instead of the values.

Here is my CGI file:

#!C:\Dwimperl\perl\bin\perl.exe
# PERL MODULES WE WILL BE USING
use CGI;
use DBI;
use DBD::mysql;
use CGI::Carp 'fatalsToBrowser';
use CGI qw(:standard);

# Config DB variables
our $platform = "mysql";
our $database = "test";
our $host = "localhost";
our $port = "3306";
our $tablename = "addressbook";
our $user = "root";
our $pw = "password";
our $q = new CGI;
our $message;
our @rows;

# DATA SOURCE NAME
$dsn = "dbi:mysql:$database:localhost:3306"; 

# PERL DBI CONNECT
$connect = DBI->connect($dsn, $user, $pw);


#Get the parameter from your html form.
$lname=$q->param('lname');
$fname=$q->param('fname');
$phone=$q->param('phone');
$email=$q->param('email');
$address=$q->param('address');
$zip=$q->param('zip');
$action=$q->param('action');
$lname1=$q->param('lname1');
$fname1=$q->param('fname1');
$phone1=$q->param('phone1');
$email1=$q->param('email1');
$address1=$q->param('address1');
$zip1=$q->param('zip1');

#Subroutines for each user function

sub addcontact{
$sql="INSERT INTO test.addressbook(last_name,first_name,address,zip,em
+ail,phone) values('$lname','$fname','$address','$zip','$email','$phon
+e')";
$sth = $connect->prepare($sql)
or die "Can't prepare $sql: $connect->errstrn";
$rv = $sth->execute;
if ($rv == 1){
  $message =  q(Record has been successfully updated!!!);
}else{
  $message =  q(<b style="color:red">Error!!while inserting records</b
+>);
}
}

sub search{
$sql="SELECT * FROM test.addressbook where last_name='$lname1' and fir
+st_name='$fname1'";
$sth = $connect->prepare($sql);
$sth->execute();
$ref = $sth->fetchall_arrayref;
foreach $row (@{$ref}){
    push @rows, @$row;
}
$rows=@rows;
if ($rows<1){
  $message =  q(<b style="color:red">Error! Record not found</b>);
}
return @rows;
}

sub deletecontact{
$sql="DELETE FROM test.addressbook where last_name='$lname1'";
$sth=$connect->prepare($sql);
$rd=$sth->execute;
if ($rd == 1){
  $message =  q(Record has been successfully deleted!!!);
}else{
  $message =  q(<b style="color:red">Error! Couldn't delete record</b>
+);
}
}

sub update{
$sql="UPDATE test.addressbook SET last_name='$lname1',first_name='$fna
+me1',address='$address1',zip='$zip1',email='$email1',phone='$phone1' 
+WHERE last_name='$lname1' and first_name='$fname1'";
$sth = $connect->prepare($sql);
$sth->execute();
$ru=$sth->execute;
}

# Choose action Add/Search/Delete/Update to call function
if ($action eq "Add"){
    addcontact()
  }
  elsif ($action eq "Search"){
    search()
  } 
  elsif ($action eq "Delete"){
    deletecontact()
  }
  elsif ($action eq "Update"){
    update()
  } 
  else {
    print " Got No parameters";
  } 


# Return to html page
my $URL = '/contactsform.html';
print $q->header( 
 -type=>"text/html");

#Print search results and ask for delete/update
print $q->start_html("Address Book"),
$q->p($message);
if ($action eq "Search"){
print
$q->h3("Search Results"),
$q->p("Last Name: $rows[1]"),
$q->p("First Name: $rows[2]"),
$q->p("Address: $rows[3]"),
$q->p("Zip: $rows[4]"),
$q->p("Phone: $rows[5]"),
$q->p("Email: $rows[6]"),
$q->start_form(),
$q->p(submit(-name =>'action',-value =>'Update'), submit(-name =>'acti
+on',-value =>'Delete')),
$q->end_form();
}

#Opens new form for updating entry
if ($action eq "Update"){
print $q->start_form(),        
$q->p("Last Name", textfield(-name  => 'lname1',-value => '$lname',)),
$q->p("First Name", textfield(-name  => 'fname1',-value => '$fname')),
$q->p("Address", textfield(-name  => 'address1',-value => '$address'))
+,
$q->p("Zip", textfield(-name  => 'zip1',-value => '$zip')),
$q->p("Phone", textfield(-name  => 'phone1',-value => '$phone')),
$q->p("Email", textfield(-name  => 'email1',-value => '$email')),
$q->p(submit("Update")),
$q->end_form();
}
print $q->p( qq!<a href="$URL">Back to Main Page</a>! );
print $q->end_html;
[download]

Here is the HTML form:

<html>
<head><title>ADDRESS BOOK</title></head>
<body bgcolor="#FFFFFF" link="#0000FF" alink="#FF0000" vlink="#C000FF"
+>
<h1 align="center">ADDRESS BOOK CONTACTS</h1>

<div style="margin:0 auto;width:50%;text-align:center">
<form method="get" action="/cgi-bin/PROJECT/sqlconfig.cgi" style="disp
+lay:inline-block;background-color:#CCDFEF">
<table>
<h2> Add New Contact</h2>
  <tr>
  <td align="right">Last Name:</td>
  <td align="left"><input type="text" name="lname" size="15" maxlength
+="50"></td>
  <td align="right">First Name:</td>
  <td align="left"><input type="text" name="fname" size="15" maxlength
+="50"></td>
  </tr>
  <tr>
  <td align="right">Phone:</td>
  <td align="left"><input type="text" name="phone" size="15" maxlength
+="50"></td>
  <td align="right">Email:</td>
  <td align="left"><input type="text" name="email" size="15" maxlength
+="50"></td>
  </tr>
  <tr>
  <td align="right">Address:</td>
  <td align="left"><input type="text" name="address" size="15" maxleng
+th="100"></td>
  <td align="right">Zip Code:</td>
  <td align="left"><input type="text" name="zip" size="15" maxlength="
+50"></td>
  </tr>
  </table>
<input type="submit" name="action" value="Add" />
<h2>Search Contacts</h2>
<table>
  <tr>
  <td align="right">Last Name:</td>
  <td align="left"><input type="text" name="lname1" size="15" maxlengt
+h="50"></td>
  <td align="right">First Name:</td>
  <td align="left"><input type="text" name="fname1" size="15" maxlengt
+h="50"></td>
  </tr>
</table>
<input type="submit" name="action" value="Search" />
</form>
</div>
</body>
</html>
[download]

Please help.

In reply to Passing form parameters same CGI page by newtoperl101

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		`&`
	<		`<`
	>		`>`
	[		`[`
	]		`]`

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.