Hello chiru, and welcome to the Monastery!

There are two major problems in your script:

  1. my $lines++ while(<FILE>);

    This re-declares $lines on every iteration of the while loop. You need to declare it once only, before the loop:

    my $lines; $lines++ while <FILE>;
  2. my $first = <FILE>;

    At this point, the filehandle FILE points to the end of the file, because this is the position it reached at the conclusion of the previous while loop. Call seek to reset it:

    seek FILE, 0, 0; my $first = <FILE>;

Note also that $ARGV has a special meaning in Perl (see perlvar#Variables-related-to-filehandles). You should use an ordinary lexical variable instead: chomp(my $file = <>);

And of course the design of this script is inefficient, since it reads the file twice. See NetWallah’s answer for a better, one-pass, approach.

Hope that helps,

Athanasius <°(((><contra mundum Iustus alius egestas vitae, eros Piratica,


In reply to Re: getting error "Use of uninitialized value $lines in concatenation (.) or string at line 6" by Athanasius
in thread getting error "Use of uninitialized value $lines in concatenation (.) or string at line 6 by chiru

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.