Still rather inefficient. Why not use bind_columns?

my %foo; # Store here when fetching fields
my $sth1 = $dbh->prepare ("select * from foo");
$sth1->execute; # added this line after [poj] spotting it was missing
# store foo.blah into $foo{blah}
$sth1->bind_columns (\@foo{@{$sth1->{NAME_lc}}});

my $sth2 = $dbh->prepare ("insert into bar (ape, monkey) values (?, ?)
+");
# foo.morg => bar.ape, foo.jume => bar.monkey
$sth2->bind_columns (\@foo{qw( morg jume )});
while ($sth1->fetch) {
    $sth2->execute;
    }

[download]

If both tables have the same fields

my %rec;
my $sth1 = $dbh->prepare ("select * from foo");
my @fields = @{$sth1->{NAME_lc}};
$sth1->bind_columns (\@rec{@{$sth1->{NAME_lc}}});

my $sth2 = do {
    local $" = ", ";
    $dbh->prepare ("insert into bar (@fields) values (@{[('?')x@fields
+]})");
    };
$sth2->bind_columns (\@rec{@fields});
while ($sth1->fetch) {
    $sth2->execute;
    }

[download]

Enjoy, Have FUN! H.Merijn

In reply to Re^2: dbi placeholders by Tux
in thread dbi placeholders by fionbarr

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.