Hello everyone.

I wrote the following subroutine recently using map and grep in the BLOCK LIST style. Line 4 had gotten long, so as you can see, I put the map, grep, and sort on separate lines. After doing that and seeing how good it looked, I began thinking about all the times I used map and grep in the EXPR, LIST format and that I may want to rewrite all of them.

Most, if not all, other people I have chatted with over my years here use the BLOCK LIST format instead of the EXPR, LIST format. I stubbornly stuck with the EXPR, LIST format. Now I am not sure if I am thinking of refactoring to use the format is normally used or if this is refactoring just to refactor. So, I am on the fence on whether or not I should do it.

What do you think?

sub index_menu {
  my $dir = shift;
  my @file_list = file_list('.');
  my $files = [
    map  { anchor( textify($_), { href => $_ } ) }
    grep { /^[A-Z].+/ &&  -f $_ }
    sort { article_sort($a, $b) }
    @file_list
  ];
  return $files;
}
[download]