A tad harsh and I dare say true only in the extreme circumstances. The Critic is just a tool and even the most blunt force tool requires skill to use properly. It doesn't require you to do anything. The Critic **should** cause you to think before making changes, either to conform or defy. But, as you point out, blind obedience is not useful.

In that sense, my question was poorly formed. Having made the decision to use eval in this version of the code, I was really looking for any other low impact suggestions I could make use of that would minimize risk and maintenance, making the rather grand assumption the Critic would agree.

Given more time, I would almost certainly take out the eval and use some other form of data store for all this, I just happen to be moving on before I'll get that chance.

Regardless, thanks for the response and opinion. We all need a good jab in the brain every so often to keep us on track.


In reply to Re^4: perlcritic compliant way to eval? by KeighleHawk
in thread perlcritic compliant way to eval? by KeighleHawk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.