Hi again all. Thanks to your help I solved my first problem, thank you again. Now what I'm trying to do is get the average value of my four matrices' elements (to then proceed to getting the standard deviation). They are four 3x3 test matrices, each one in a different file. They are test cases as my real matrices are thousands of lines long and the number of files is again thousands.

When I print them with  $line[$a][$b] they look correct, so I've commented this line out as it was used as a test to see if they look ok. The output I'm getting if I try to get the sum of the elements and then the mean, is  Use of uninitialized value in addition (+) at test_SD_Wednesday.pl line 52 and a bunch of wrong numbers as sum/averages. I'm pretty sure I'm screwing something up badly but I can't figure out what. Any hints please? I'm starting to get scared my supervisors will really shout at me or think I'm an idiot if I tell them it's taken me 10 days to have a script that doesn't work...

Finally can someone comment on the indentation? Does it make sense they way I did it? It looks less messy but no clue if I got the philosophy behind it.

#/bin/perl/

use strict;
use warnings;
use autodie;

my $molec = "1ac6";
my $cluster;
my $times;
my $input;

my $path = "/media/RAIDstorage/home/athina/dist-analysis/${molec}/time
+series/test";

my $line;
my @files;
@files = `ls $path\/$molec-times*`;

foreach (@files) {

 my $a;
 my $b;

 my $m_avrg;

 my @m_avrg;
 undef @m_avrg;

 my @list;
 my $list;

 my $aver;

 /${molec}-times-(\d+)-clust(\d{1})/;

 $times = $1;
 $cluster = $2;

 open $input, '<', "$path\/${molec}-times-${times}-clust${cluster}.out
+" or die $!;

 while ($line = <$input>) {
  chomp $line;

  push @list, [split/\s+/, $line];

 } # while input

 close $input;

  for ($a=0; $a<=2; $a++) {
   for ($b=0; $b<=2; $b++) {
    #print "$list[$a][$b] "; # check matrices
    $m_avrg[$a][$b] = ($m_avrg[$a][$b] + $list[$a][$b]);
    print  "$m_avrg[$a][$b] \n";
   }
   print " \n";
  }

   print "average\n";
    
   for ($a=0; $a<=2; $a++) {
    for ($b=0; $b<=2; $b++) {
     $m_avrg[$a][$b] = $m_avrg[$a][$b] / 4;
     print "$m_avrg[$a][$b] ";
     }
    print "\n";
   }

} # foreach file in loop

[download]

In reply to Re: read files into 2D arrays and print element? by fasoli
in thread read files into 2D arrays and print element? by fasoli

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.