Hi, as was pointed out in a fashion by another monk, you have a great deal of duplication in your code. One of the great things about variables is that they are, um, variable. That is, they can hold variable values. Thus, you don't need a different variable for each piece of data you are processing. Then, once you are reusing variables, you will find that you can reuse code that processes them.

Another important technique is to use meaningful variable names, so that a reader of code, or you a week later, can understand what is going on.

So for example I might gently rewrite your code to contain something like: 

...
my @infiles = @ARGV;    

for my $file ( @infiles ) {
    my ($descriptions, $sequences) = ParseFile( $file );
    
    ... # output the data here    
}

...

sub ParseFile {
    my $file = shift;

    my %descriptions = my %sequences = ();
    open (my $fh,  '<', $file)  or die "Cannot open input file $file: 
+$!\n";
    while ( my $line = <$fh> ) {
        chomp $line;
        if ( $line =~ m/^>(\S+)\s(.+)/ ) {
            $descriptions{$1} = $2;
        } else {
             $sequences{$1} = $.;
        }
    }

    return (\%descriptions, \%sequences);
}

...

[download]
(example code only)

Hope this helps!


The way forward always starts with a minimal test.

In reply to Re: Print Output to New File by 1nickt
in thread Print Output to New File by FIJI42

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.