Good stuff!

I have created the Menu and it is accepting params so, it works fine when the id is typed, but it doesn't work when it is left blank ""

I am struggling with this error message: Can't locate object method "selectall_array" via package "DBI::db" at ./test.pl line 60.

Well, that is the line 60: @id = map{ $_->[0] } $dbh->selectall_array($sql,undef,'no');

what am I doing wrong here?

#!/usr/bin/perl -W

use DBI;
use Text::CSV_XS;

# GLOBALS
@id = "";
$dbname = "";
$user = "";

# MAIN MENU
# Don't allow duplicated arguments and blank/undef arguments
# except for id (in this case blank/undef id means all ids)
foreach my $arg (@ARGV)
{
    if ($arg eq '-h' || $arg eq '--help')
    {
        die "Script usage manual here\n";
        exit;
    }
    
    if ($arg =~ /^(\w+)$/)
    {
        die "Error: Multiple databases: $dbname and $arg." if $dbname;
        
        $dbname = $1 ; next;
    }
    
    if ($arg =~ /^--?u(\w+)$/)
    {
        die "Error: Multiple users $user and $arg." if $user;
        
        $user = $1 ; next;
    }
    
    if ($arg =~ /^--?id(\d+)$/)
    {
        die "Error: Multiple ids specified: -id$id[0] and $arg.\n" if 
+$id[0];

        $id[0] = $1 ; next;
    }
    elsif ($arg =~ /^--?id(\S+|)$/)
    {
        die "Error id format, use -id<integer>\n";
    }    
}

die "No database, type <dbname>\n" unless $dbname;
die "No username, use -u<username>\n" unless $user;


# DBI CONNECTION
my $dbh = get_dbh();

# EXEC
if ($id[0] eq "")
{   
    my $sql = "SELECT DISTINCT id from mytable
             WHERE active = ?";
    @id = map{ $_->[0] } $dbh->selectall_array($sql,undef,'no');
}

for my $id (@id)
{
  my @query =
  (
    ["SELECT id FROM mytable     WHERE id=? AND salary >= 1","csvfile1
+_$id.csv"],
    ["SELECT name FROM mytable   WHERE id=? AND salary >= 1","csvfile2
+_$id.csv"],
    ["SELECT salary FROM mytable WHERE id=? AND salary >= 1","csvfile3
+_$id.csv"],
    ["SELECT dept FROM mytable   WHERE id=? AND salary >= 1","csvfile4
+_$id.csv"],
  );

  for (@query)
  {
    run_query(@$_,$id);
  }
}

# SUBROUTINES
sub get_dbh
{
    my($dbh) = DBI->connect("dbi:IngresII:$dbname","$user","")
        or die "Could not connect to database $dbname\n";
    
    return $dbh;
}

sub run_query 
{
    my ($sql, $csvfile, $id) = @_;
    print "Running $sql for $id\n";
    
    open my $fh, '>', $csvfile or die "Could not open $csvfile: $!";

    my $csv = Text::CSV_XS->new ({ binary => 1, eol => "\n" });
    my $sth = $dbh->prepare ($sql); 
    $sth->execute($id);
    $csv->print($fh, $sth->{NAME_lc});
    my $count = 1;
    
    while (my $row = $sth->fetchrow_arrayref)
    {
        $csv->print($fh, $row);
        ++$count;
    }
    
    close $fh;
    
    print "ID: $id, $count lines dumped to $csvfile\n";
}
[download]

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.