Since you get to know the filename in the loop, you could simply store your lines in a string, then write it at once when you exit the loop. This is also much more efficient than opening the file each time for writing, also less prone to concurrency problems.

Example:

my $buffer = "first line\n"; foreach my $do (keys %doing) { # DO DB query for $do where fo $do can be serveral bodylines; $buffer .= $bodyline . "\n"; } $buffer .= "last line\n"; # now you know the file name open FILE, ">$name" or die "bla bla"; print FILE $buffer; close FILE;

-- TMTOWTDI


In reply to Re: Logic problem by trantor
in thread Logic problem by toadi

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.