when you change the code to print out the values of $name, $1, and $2: 
foreach $name (keys %book) {   #write the data
    print "$name \n";
    $name =~ /(.+)&(.+)/;
    print "$1, $2 \n";
    if ($2 =~ /^0$/) {
        print BOOK "$1,::";
    } else {
        print BOOK"$1,$2::";
    }
    for ( 0 .. $#{ $book{$name} } ) {
         print BOOK $def[$_+2] . ":" . $book{$name}[$_] . "::" unless 
+$book{$name}[$_] =~ /^0$/;
    }
    print BOOK "\n";
}

[download]
you get the correct output, and it shows $1 and $2 are initialized, but you still get the uninitialized error. Here is the output when you pass it School&0 and one number: 

school&0

school, 0 
# Use of uninitialized value, <> chunk 7.
File 'untitled:Desktop Folder:Will's Stuff:Applications:MacPerl ƒ:phonebook'; Line 57
so that isnt the problem. Loop lables are a good idea, though, thanks

In reply to Re: Re: uninitialized value in phonebook program by smgfc
in thread uninitialized value in phonebook program by smgfc

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.