Not bad. But note that at the moment you are getting duplicates - e.g. (4,3,5) and (3,4,5). You could avoid this, and speed your code up significantly, by replacing 

for ($b=1; $b<$max; $b++) {

[download]
with 
for ($b=$a; $b<$max; $b++) {

[download]

You might also want to avoid your third embedded loop. It doesn't matter much if you do pythagoras.pl 10, but pythagoras.pl 1000 is sloooooooow.

You already know a and b, so you just need to test if a^2 + b^2 is a perfect square. For that you probably need one of the Math modules.

Update

Doh! You can just do **(1/2) to get the square root. Back to maths class for me. Although, will integer handling bite you in the ass if you just do 

my $h = ($a**2 + $b**2) ** (1/2);
if ($h == int $h) {
    print "$a $b $h is a winner\n";
}

[download]

? I don't know. Answers on a postcard.

dave hj~

In reply to Re: Pythagorean's theorem by dash2
in thread Pythagorean's theorem by fuzzyping

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.