While we're at it, here is some general comments about your code:

• You declare a global in a subroutine. This sort of loose coupling is a big no-no, because it makes subtle bugs, and makes code more confusing. Consider returning the hash
• You then take the %formdata hash and after generating it say my %formdata. Apart from the fact that Globals R Bad, this is a extraneous construct. You can get rid of it.
• As has been mentioned, use a module to handle the sending of mail. It's more complicated than it looks (and it looks complicated). The module will save you the headache.
• There is no need to iterate through each param to build your hash. CGI.pm provides a method which will give you a hash straight off, and thus be more efficient and let you get rid of the sub all together.
• You use strict. Nice. But you also might want to use warnings, and most definately turn on -T for tainting, to ensure that your programs stay secure. You should do this at least for EVERY CGI program you write.

I also just want to say that you've come a long way since your early work you asked everyone in th CB to bugcheck. keep learning.

Cheers,
Erik

---

In reply to Re: Contact Form 2 by erikharrison
in thread Contact Form 2 by venimfrogtongue

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":





---

• Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
• Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
• Read Where should I post X? if you're not absolutely sure you're posting in the right place.
• Please read these before you post! —
  • How do I compose an effective node title?
  • How do I post a question effectively?
  • Markup in the Monastery
• Posts may use any of the Perl Monks Approved HTML tags:

  a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

• You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

  	For:		Use:
  	&		&
  	<		&lt;
  	>		&gt;
  	[		&#91;
  	]		&#93;

• Link using PerlMonks shortcuts! What shortcuts can I use for linking?
• See Writeup Formatting Tips and other pages linked from there for more info.